Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from XLF (back) to LCL #699

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Switch from XLF (back) to LCL #699

merged 1 commit into from
Aug 31, 2021

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Aug 31, 2021

Actual LCL translations will come later.

Comparable to microsoft/vs-validation#89 and microsoft/vs-mef#212.

@AArnott AArnott added this to the v2.9 milestone Aug 31, 2021
Actual LCL translations will come later.
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #699 (5488d3d) into main (1c3f264) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   89.95%   90.08%   +0.12%     
==========================================
  Files          60       60              
  Lines        5158     5162       +4     
==========================================
+ Hits         4640     4650      +10     
+ Misses        518      512       -6     
Impacted Files Coverage Δ
src/StreamJsonRpc/Reflection/RpcTargetInfo.cs 92.01% <0.00%> (-0.77%) ⬇️
src/StreamJsonRpc/JsonRpc.cs 92.93% <0.00%> (+1.06%) ⬆️
src/StreamJsonRpc/WebSocketMessageHandler.cs 76.56% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3f264...5488d3d. Read the comment docs.

@AArnott AArnott requested a review from milopezc August 31, 2021 18:52
@AArnott AArnott merged commit c6a15bf into microsoft:main Aug 31, 2021
@AArnott AArnott deleted the xlfToLcl branch August 31, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants