Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from XLF (back) to LCL #699

Merged
merged 1 commit into from
Aug 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<Nullable>enable</Nullable>
<AnalysisLevel>latest</AnalysisLevel>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<UpdateXlfOnBuild Condition=" '$(UpdateXlfOnBuild)' == '' ">true</UpdateXlfOnBuild>

<Company>Microsoft</Company>
<Authors>Microsoft</Authors>
Expand Down
1 change: 0 additions & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ parameters:

variables:
TreatWarningsAsErrors: true
UpdateXlfOnBuild: false # force build breaks if xlf files aren't updated on dev box with resx changes
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
BuildConfiguration: Release
BuildPlatform: Any CPU
Expand Down
15 changes: 15 additions & 0 deletions azure-pipelines/artifacts/LocBin.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Identify LCE files and the binary files they describe
$BinRoot = [System.IO.Path]::GetFullPath("$PSScriptRoot\..\..\bin")
$FilesToCopy = @()
$FilesToCopy += Get-ChildItem -Recurse -File -Path $BinRoot |? { $_.FullName -match '\\Localize\\' }

Get-ChildItem -rec "$BinRoot\*.lce" -File | % {
$FilesToCopy += $_
$FilesToCopy += $_.FullName.SubString(0, $_.FullName.Length - 4)
}

$FilesToCopy += Get-ChildItem -rec "$BinRoot\*.lcg" -File | % { [xml](Get-Content $_) } | % { $_.lcx.name }

@{
"$BinRoot" = $FilesToCopy;
}
5 changes: 5 additions & 0 deletions azure-pipelines/microbuild.before.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,8 @@ steps:
inputs:
signType: $(SignType)
displayName: Install MicroBuild Signing Plugin

- task: MicroBuildLocalizationPlugin@3
inputs:
languages: $(LocLanguages)
displayName: Install MicroBuild Localization Plugin
1 change: 0 additions & 1 deletion azure-pipelines/official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ stages:
- stage: Build
variables:
TreatWarningsAsErrors: true
UpdateXlfOnBuild: false # force build breaks if xlf files aren't updated on dev box with resx changes
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
BuildConfiguration: Release
BuildPlatform: Any CPU
Expand Down
6 changes: 6 additions & 0 deletions azure-pipelines/variables/LocLanguages.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
## For faster PR/CI builds localize only for 2 languages, ENU and JPN provide good enough coverage
if ($env:BUILD_REASON -eq 'PullRequest') {
'ENU,JPN'
} else {
'VS'
}
14 changes: 14 additions & 0 deletions init.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
Skips the package restore step.
.PARAMETER Signing
Install the MicroBuild signing plugin for building test-signed builds on desktop machines.
.PARAMETER Localization
Install the MicroBuild localization plugin for building loc builds on desktop machines.
The environment is configured to build pseudo-loc for JPN only, but may be used to build
all languages with shipping-style loc by using the `/p:loctype=full,loclanguages=vs`
when building.
.PARAMETER OptProf
Install the MicroBuild OptProf plugin for building optimized assemblies on desktop machines.
.PARAMETER AccessToken
Expand All @@ -50,6 +55,8 @@ Param (
[Parameter()]
[switch]$Signing,
[Parameter()]
[switch]$Localization,
[Parameter()]
[switch]$OptProf,
[Parameter()]
[string]$AccessToken
Expand Down Expand Up @@ -100,6 +107,13 @@ try {
$EnvVars['SignType'] = "Test"
}

if ($Localization) {
Write-Host "Installing MicroBuild localization plugin" -ForegroundColor $HeaderColor
& $InstallNuGetPkgScriptPath MicroBuild.Plugins.Localization -source $MicroBuildPackageSource -Verbosity $nugetVerbosity
$EnvVars['LocType'] = "Pseudo"
$EnvVars['LocLanguages'] = "JPN"
}

if ($OptProf) {
Write-Host "Installing MicroBuild OptProf plugin" -ForegroundColor $HeaderColor
& $InstallNuGetPkgScriptPath MicroBuild.Plugins.OptProf -source $MicroBuildPackageSource -Verbosity $nugetVerbosity
Expand Down
1 change: 0 additions & 1 deletion src/StreamJsonRpc/StreamJsonRpc.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
<PackageReference Include="System.Reflection.Emit" Version="4.7.0" />
<PackageReference Include="System.Threading.Tasks.Dataflow" Version="5.0.0" PrivateAssets="compile" />
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
<PackageReference Include="XliffTasks" Version="1.0.0-beta.19505.1" PrivateAssets="all" />
</ItemGroup>
<ItemGroup>
<AdditionalFiles Include="$(TargetFramework)\PublicAPI.Shipped.txt" />
Expand Down
357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.cs.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.de.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.es.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.fr.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.it.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.ja.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.ko.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.pl.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.pt-BR.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.ru.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.tr.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.zh-Hans.xlf

This file was deleted.

357 changes: 0 additions & 357 deletions src/StreamJsonRpc/xlf/Resources.zh-Hant.xlf

This file was deleted.