Use 'resolveDebugConfigWithSubVariables' #6328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses the DebugConfigurationProvider.resolveDebugConfigurationWithSubstitutedVariables which allows the debug configuration to wait for the preLaunchTask to complete before continuing on and resolving variables that may have been set in the 'tasks.json'. This also resolves the logging issue where the 'Build and Debug Active File' preLaunchTask uses the current file but we switch to the output window for logging.
sean-mcmanus
approved these changes
Oct 15, 2020
|
@WardenGnaw I think this broke Linux/Mac debugging with F5 (Build and Debug Active File). |
sean-mcmanus
added a commit
that referenced
this pull request
Oct 16, 2020
This reverts commit 2ec525e.
sean-mcmanus
added a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
DebugConfigurationProvider.resolveDebugConfigurationWithSubstitutedVariables
which allows the debug configuration to wait for the
preLaunchTasktocomplete before continuing on and resolving environment variables or processes
that may have been set in the 'tasks.json'.
This also resolves the logging issue where the 'Build and Debug Active
File' preLaunchTask uses the current file but we switch to the output
window for logging.
Undo: #6304 but VS Code bug is still valid.
Related Issues: #5287