Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use 'resolveDebugConfigWithSubVariables' (#6328)" #6331

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

sean-mcmanus
Copy link
Collaborator

This reverts commit 2ec525e.

@sean-mcmanus sean-mcmanus requested review from WardenGnaw and a team October 16, 2020 02:16
@sean-mcmanus
Copy link
Collaborator Author

sean-mcmanus commented Oct 16, 2020

I'm checking if this fixes F5 debugging.

@sean-mcmanus
Copy link
Collaborator Author

Yeah, undoing this fixes debugging.

@WardenGnaw Something with this change breaks the F5 scenario.

@sean-mcmanus sean-mcmanus merged commit a052d76 into master Oct 16, 2020
@WardenGnaw
Copy link
Member

Broken in VS Code Insiders. Works in Release.

See bug: microsoft/vscode#108835

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2020
@bobbrow bobbrow deleted the seanmcm/undoResolveDebugConfigWithSubVariables branch January 5, 2021 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants