support yarn pnp for nodeAddonIncludes #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesteery
force-pushed
the
patch-1
branch
2 times, most recently
from
1330360
to
6855ddb
Compare
|
|
This solves problems with Yarn PnP and node addon includes.
|
Thanks for the contribution. We'll try to review this later this week. |
sean-mcmanus
requested changes
Mar 9, 2021
There was a problem hiding this comment.
The stdout I get from yarn is
'yarn node v1.19.1\n"<workspaceFolder>\node_modules\\node-addon-api"\nDone in 0.51s.'
which isn't processed correctly because the code just expects the middle line. Is that supposed to work correctly and/or how are you getting it to work?
|
This is normal, because it's for Yarn Berry. |
Ah, thanks. I'll look into that tomorrow. |
sean-mcmanus
approved these changes
Mar 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves problems with Yarn PnP and node addon includes.
✅ Works correctly.