Fix problem with markdown being passed to pylance (#8768)

* Fix problem with markdown being passed to pylance * Add news entry
microsoft · Jan 24, 2022 · adb20eb · adb20eb
1 parent a21a19d
commit adb20eb
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/news/2 Fixes/8769.md b/news/2 Fixes/8769.md
@@ -0,0 +1 @@
+Fix problem with markdown cells causing off by one errors in notebooks.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2065,7 +2065,7 @@
         "@jupyterlab/services": "^6.1.17",
         "@lumino/widgets": "^1.28.0",
         "@nteract/messaging": "^7.0.0",
-        "@vscode/jupyter-lsp-middleware": "^0.2.34",
+        "@vscode/jupyter-lsp-middleware": "^0.2.36",
         "ansi-to-html": "^0.6.7",
         "arch": "^2.1.0",
         "bootstrap": "^4.3.1",

diff --git a/src/client/datascience/notebook/intellisense/intellisenseProvider.ts b/src/client/datascience/notebook/intellisense/intellisenseProvider.ts
@@ -185,7 +185,10 @@ export class IntellisenseProvider implements INotebookLanguageClientProvider, IE
             notebookId = activeInterpreter ? this.getInterpreterIdFromCache(activeInterpreter) : undefined;
         }
 
-        return interpreterId == notebookId;
+        // Cell also have to support python
+        const cell = notebook?.getCells().find((c) => c.document.uri.toString() === uri.toString());
+
+        return interpreterId == notebookId && (!cell || cell.document.languageId === 'python');
     }
 
     private getNotebookHeader(uri: Uri) {