Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with markdown being passed to pylance #8768

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jan 22, 2022

Fixes: #8769

With pylance handling intellisense, we were also passing non python cells along. This filters those out so pylance never sees them.

Before change:

image

Notice the off by one error on the diagnostics

After change:

image

@rchiodo rchiodo requested a review from a team as a code owner January 22, 2022 01:15
@rchiodo
Copy link
Contributor Author

rchiodo commented Jan 22, 2022

No bug yet entered for this, as nobody else is using pylance yet.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #8768 (1084ebd) into main (c2bbbaa) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #8768   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        381     381           
  Lines      24535   24536    +1     
  Branches    3772    3774    +2     
=====================================
+ Hits       17621   17631   +10     
+ Misses      5394    5382   -12     
- Partials    1520    1523    +3     
Impacted Files Coverage Δ
...ence/notebook/intellisense/intellisenseProvider.ts 81% <100%> (+<1%) ⬆️
...lient/datascience/variablesView/notebookWatcher.ts 90% <0%> (-3%) ⬇️
src/client/datascience/raw-kernel/rawSocket.ts 84% <0%> (-1%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 69% <0%> (+1%) ⬆️
src/client/datascience/dataScienceSurveyBanner.ts 75% <0%> (+6%) ⬆️

@rchiodo rchiodo merged commit adb20eb into main Jan 24, 2022
@rchiodo rchiodo deleted the rchiodo/markdown_with_pylance branch January 24, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown cells cause intellisense to be off by the length of the markdown cells
3 participants