Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge june release back #6193

Merged
merged 23 commits into from
Jun 8, 2021
Merged

merge june release back #6193

merged 23 commits into from
Jun 8, 2021

Conversation

DavidKutu
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

David Kutugata and others added 19 commits June 1, 2021 22:15
* release candidate

* Memorial Day API changes (#6056)

* update changelog

Co-authored-by: Ian Huff <ianhu@microsoft.com>
* change version to 2021.6.x

* match packagejson and changelog versions

* 6/2 API Changes (#6089)

Co-authored-by: Ian Huff <ianhu@microsoft.com>
* Remove our Run Above/Below commands (#6026)

* Update changelog
* update version to 2021.6.99 to be able to filter
update changelog

* update package lock and VSCode api

* don

* remove api changes in the code
* Fix test failures resulting from VSCodes Notebook Start page (#6111)

* Disable kernel auto startup in untrusted workspace (#6088)

* Disable kernel auto startup in untrusted workspace

* Fixes

* Misc

* oops

* misc

* Fixes to breaking tests (#6074)

Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
* add component governance file

* remove npm components
* final update

* update changelog
revert change on gulpfile
@DavidKutu DavidKutu requested a review from a team as a code owner June 7, 2021 23:03
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #6193 (f2789d1) into main (a37eb12) will decrease coverage by 0%.
The diff coverage is 84%.

@@          Coverage Diff           @@
##            main   #6193    +/-   ##
======================================
- Coverage     72%     71%    -1%     
======================================
  Files        399     399            
  Lines      26869   26895    +26     
  Branches    3954    3961     +7     
======================================
- Hits       19428   19314   -114     
- Misses      5790    5945   +155     
+ Partials    1651    1636    -15     
Impacted Files Coverage Δ
...rc/client/datascience/jupyter/debuggerVariables.ts 75% <75%> (-1%) ⬇️
...ient/datascience/jupyter/kernels/kernelSelector.ts 87% <76%> (-4%) ⬇️
...rc/client/datascience/commands/notebookCommands.ts 69% <100%> (+1%) ⬆️
src/client/datascience/jupyter/kernelVariables.ts 69% <100%> (+1%) ⬆️
...science/jupyter/kernels/kernelDependencyService.ts 89% <100%> (+<1%) ⬆️
...ience/variablesView/variableViewMessageListener.ts 22% <0%> (-78%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 14% <0%> (-72%) ⬇️
...c/client/datascience/variablesView/variableView.ts 18% <0%> (-58%) ⬇️
src/client/datascience/webviews/webviewViewHost.ts 19% <0%> (-53%) ⬇️
...t/datascience/jupyter/jupyterInvalidKernelError.ts 66% <0%> (-34%) ⬇️
... and 15 more

([#5798](https://github.com/Microsoft/vscode-jupyter/issues/5798))
1. Add support for [Virtual Workspaces](https://github.com/microsoft/vscode/wiki/Virtual-Workspaces).
([#5803](https://github.com/Microsoft/vscode-jupyter/issues/5803))
1. Losslessly compressed PNG images to save ~20KB.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs a thank you?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is there, line 84

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see what you mean

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No an individual contributor thank you for this submission.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put it on the release branch, and it will be merged after we release

if: github.event_name == 'schedule' && github.ref == 'refs/heads/main'
run: |
echo "release_channel=insider" >> $GITHUB_ENV
# - name: insiders channel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just make sure that we turn it back on with the versions updated when new insiders engine version is out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will not forget
#6195

@DavidKutu DavidKutu merged commit 5580aa1 into main Jun 8, 2021
@DavidKutu DavidKutu deleted the david/mergeJuneReleaseBack branch June 8, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants