6/2 API Changes #6089

IanMatthewHuff · 2021-06-02T22:37:01Z

For #6086

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
Title summarizes what is changing.
Has a news entry file (remember to thank yourself!).
Appropriate comments and documentation strings in the code.
Has sufficient logging.
Has telemetry for enhancements.
Unit tests & system/integration tests are added/updated.
Test plan is updated as appropriate.
package-lock.json has been regenerated by running npm install (if dependencies have changed).

…to main

IanMatthewHuff · 2021-06-02T22:38:12Z

For some reason my local branch is a bit messed up, it seems to think there was an earlier commit in here. But that was just a previously checked in API submission, so I think this should be fine. I'll just rebase my local after this.

IanMatthewHuff · 2021-06-02T22:39:27Z

src/client/datascience/jupyter/kernels/cellExecution.ts

@@ -185,7 +185,8 @@ export class CellExecution {
            `Cell Exec contents ${this.cell.document.getText().substring(0, 50)}...`
        );
        if (!this.canExecuteCell()) {
-            this.execution?.end({});
+            // End state is bool | undefined not optional. Undefined == not success or failure


The new tristate here for success is a bit funky so I called it out with a comment.

IanMatthewHuff · 2021-06-02T22:40:31Z

src/client/datascience/notebook/contentProvider.ts

@@ -44,16 +44,15 @@ export class NotebookContentProvider implements VSCNotebookContentProvider {
        if (!this.compatibilitySupport.canOpenWithVSCodeNotebookEditor(uri)) {
            // If not supported, return a notebook with error displayed.
            // We cannot, not display a notebook.
+            const cellData = new NotebookCellData(


It's funny I thought that typescript had some syntactic sugar for this, like a C# field initializer syntax, but didn't see it.

src/client/datascience/notebook/helpers/executionHelpers.ts

codecov-commenter · 2021-06-02T23:03:30Z

Codecov Report

Merging #6089 (084b90b) into main (f6acbbc) will decrease coverage by 9%.
The diff coverage is 32%.

❗ Current head 084b90b differs from pull request most recent head 588eda8. Consider uploading reports for the commit 588eda8 to get more accurate results

@@           Coverage Diff           @@
##            main   #6089     +/-   ##
=======================================
- Coverage     71%     62%    -10%     
=======================================
  Files        398     398             
  Lines      26832   26848     +16     
  Branches    3949    3950      +1     
=======================================
- Hits       19244   16818   -2426     
- Misses      5964    8628   +2664     
+ Partials    1624    1402    -222

Impacted Files	Coverage Δ
...lient/datascience/jupyter/kernels/cellExecution.ts	`6% <0%> (-65%)`	⬇️
src/client/datascience/notebook/contentProvider.ts	`48% <0%> (-25%)`	⬇️
...t/datascience/notebook/helpers/executionHelpers.ts	`35% <0%> (-42%)`	⬇️
...t/datascience/notebook/vscodeNotebookController.ts	`8% <0%> (-69%)`	⬇️
src/client/datascience/utils.ts	`63% <ø> (ø)`
src/client/common/application/notebook.ts	`61% <50%> (-26%)`	⬇️
...ent/datascience/jupyter/kernels/kernelExecution.ts	`12% <50%> (-55%)`	⬇️
src/client/datascience/notebook/helpers/helpers.ts	`40% <69%> (-32%)`	⬇️
...ient/datascience/jupyter/kernels/kernelProvider.ts	`16% <0%> (-80%)`	⬇️
.../datascience/jupyter/kernels/cellExecutionQueue.ts	`10% <0%> (-79%)`	⬇️
... and 141 more

IanMatthewHuff · 2021-06-03T00:04:09Z

Tests look reasonable running manually. Squashing change now. Current failures are expected due to API changes.

* change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * update verion, engine revert change on gulpfile * merge main * revert engine to 1.57-insider * delete news files that are on the changelog * disable insiders build Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * add missing thanks to changelog (#6197) * Skip uploading vsix to azure blob store (#6204) * publish release * publish release * remove last 2 numbers from release (#6219) * publish release * fix conflicts * update engine to 1.58.0-insider * return engine version to 1.57.0-insider * Do not activate Python before opening nb (#6201) (#6230) * publish release Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* release candidate (#6059) * release candidate * Memorial Day API changes (#6056) * update changelog Co-authored-by: Ian Huff <ianhu@microsoft.com> * Memorial Day API changes (#6056) * Send only error type in reason (#6067) * Fallback for sys.prefix not being returned by Python extension (#6053) * Fixes to toggling output (#6068) * Better telemetry when we don't find a matching kernel (#6060) * Better data when fail to find kernel connection (#6070) * change version and API port (#6085) * change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com> * Port #6025 to release (#6103) * Remove our Run Above/Below commands (#6026) * Update changelog * Fix pervasive test issue with editor properties (#6100) (#6106) * update version to 2021.6.99 to be able to filter (#6122) * update version to 2021.6.99 to be able to filter update changelog * update package lock and VSCode api * don * remove api changes in the code * Port Don's fixes (#6115) * Fix test failures resulting from VSCodes Notebook Start page (#6111) * Disable kernel auto startup in untrusted workspace (#6088) * Disable kernel auto startup in untrusted workspace * Fixes * Misc * oops * misc * Fixes to breaking tests (#6074) Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Breaking changes ports to release (2 commits) (#6140) * add component governance file (#6166) * add component governance file * remove npm components * Cherry pick changes from main branch into release (#6174) * final update (#6176) * final update * update changelog * add missing thanks to changelog (#6197) * Skip uploading vsix to azure blob store (#6204) * publish release * publish release * remove last 2 numbers from release (#6219) * publish release * Do not activate Python before opening nb (#6201) (#6230) * publish release * Port LiveKernelModel fix to release for point release (#6264) * Port keybinding updates to release (#6268) * Contribute shift+enter, ctrl+enter, L, shift+L (#6205) * Ctrl+Enter should put cell into command mode after executing (#6231) * Update CHANGELOG and remove news * port test fix (#6275) * Fix Restarting kernel... test (#6267) * wait for the restart command * add news file * update changelog * Fix native notebook interrupt toolbar (#6280) (#6282) * update changelog (#6284) * -update version -update changelog * leave version as it was * Respect jupyter.enableKeyboardShortcuts setting and enable ctrl+enter in command mode (#6293) * publish release * fix gulpfile * undo change Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

Ian Huff and others added 14 commits May 19, 2021 13:35

update proposed API

b8f6ad3

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

815fc82

…to main

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

3644c15

…to main

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

d25acf9

…to main

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

a2e9063

…to main

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

1882125

…to main

Merge branch 'main' of https://github.com/microsoft/vscode-jupyter in…

2d8af3e

…to main

new API

9120e3d

notebooks => workspace rename

df1a40c

execution timing changes

e0414dd

id and execution order

623053b

NotebookCellData ctor change

af3716d

view type change

d21da10

prettier pass

084b90b

IanMatthewHuff commented Jun 2, 2021

View reviewed changes

Ian Huff added 2 commits June 2, 2021 15:41

remove comment

598e245

remove comment

0a90b00

IanMatthewHuff marked this pull request as ready for review June 2, 2021 22:45

IanMatthewHuff requested a review from a team as a code owner June 2, 2021 22:45

joyceerhl approved these changes Jun 2, 2021

View reviewed changes

DonJayamanne reviewed Jun 2, 2021

View reviewed changes

src/client/datascience/notebook/helpers/executionHelpers.ts Outdated Show resolved Hide resolved

DonJayamanne approved these changes Jun 2, 2021

View reviewed changes

review feedback

588eda8

DavidKutu approved these changes Jun 2, 2021

View reviewed changes

IanMatthewHuff merged commit 3b30f83 into main Jun 3, 2021

IanMatthewHuff deleted the dev/ianhu/apiChanges2 branch June 3, 2021 00:04

DavidKutu pushed a commit that referenced this pull request Jun 3, 2021

6/2 API Changes (#6089)

6f2b31b

DavidKutu mentioned this pull request Jun 3, 2021

change version and API port #6085

Merged

DavidKutu pushed a commit that referenced this pull request Jun 3, 2021

change version and API port (#6085)

3e7672e

* change version to 2021.6.x * match packagejson and changelog versions * 6/2 API Changes (#6089) Co-authored-by: Ian Huff <ianhu@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

6/2 API Changes #6089

6/2 API Changes #6089

IanMatthewHuff commented Jun 2, 2021

IanMatthewHuff commented Jun 2, 2021

IanMatthewHuff Jun 2, 2021

IanMatthewHuff Jun 2, 2021

codecov-commenter commented Jun 2, 2021

IanMatthewHuff commented Jun 3, 2021

6/2 API Changes #6089

6/2 API Changes #6089

Conversation

IanMatthewHuff commented Jun 2, 2021

IanMatthewHuff commented Jun 2, 2021

IanMatthewHuff Jun 2, 2021

Choose a reason for hiding this comment

IanMatthewHuff Jun 2, 2021

Choose a reason for hiding this comment

codecov-commenter commented Jun 2, 2021

Codecov Report

IanMatthewHuff commented Jun 3, 2021