Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native notebook interrupt toolbar #6280

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix native notebook interrupt toolbar #6280

merged 1 commit into from
Jun 15, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #6254

@DonJayamanne DonJayamanne requested a review from a team as a code owner June 14, 2021 22:34
@codecov-commenter
Copy link

Codecov Report

Merging #6280 (0bb374d) into main (6b1c4e9) will decrease coverage by 0%.
The diff coverage is 75%.

@@          Coverage Diff          @@
##            main   #6280   +/-   ##
=====================================
- Coverage     72%     72%   -1%     
=====================================
  Files        401     401           
  Lines      27051   27052    +1     
  Branches    3987    3987           
=====================================
- Hits       19545   19543    -2     
- Misses      5860    5862    +2     
- Partials    1646    1647    +1
Impacted Files Coverage Δ
...e/interactive-ipynb/nativeEditorCommandListener.ts 49% <50%> (+<1%) ⬆️
...client/datascience/commands/activeEditorContext.ts 90% <100%> (+2%) ⬆️
...ent/datascience/jupyter/pythonVariableRequester.ts 72% <0%> (-2%) ⬇️
...t/datascience/kernel-launcher/localKernelFinder.ts 80% <0%> (-2%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 76% <0%> (-1%) ⬇️
...active-common/intellisense/intellisenseProvider.ts 74% <0%> (+<1%) ⬆️
...client/datascience/kernel-launcher/kernelDaemon.ts 54% <0%> (+1%) ⬆️

@DonJayamanne DonJayamanne merged commit 3c5fb06 into main Jun 15, 2021
@DonJayamanne DonJayamanne deleted the issue6254FixInterruptToolbar branch June 15, 2021 00:05
DonJayamanne added a commit that referenced this pull request Jun 15, 2021
@DonJayamanne
Fix native notebook interrupt toolbar (#6280)
74fe841
DonJayamanne added a commit that referenced this pull request Jun 15, 2021
@DonJayamanne
Fix native notebook interrupt toolbar (#6280) (#6282)
cce1a65
DavidKutu pushed a commit that referenced this pull request Jun 16, 2021
@IanMatthewHuff @DonJayamanne @joyceerhl
point release back to main (#6301)
3fd9151 
* release candidate (#6059)

* release candidate

* Memorial Day API changes (#6056)

* update changelog

Co-authored-by: Ian Huff <ianhu@microsoft.com>

* Memorial Day API changes (#6056)

* Send only error type in reason (#6067)

* Fallback for sys.prefix not being returned by Python extension (#6053)

* Fixes to toggling output (#6068)

* Better telemetry when we don't find a matching kernel (#6060)

* Better data when fail to find kernel connection (#6070)

* change version and API port (#6085)

* change version to 2021.6.x

* match packagejson and changelog versions

* 6/2 API Changes (#6089)

Co-authored-by: Ian Huff <ianhu@microsoft.com>

* Port #6025 to release (#6103)

* Remove our Run Above/Below commands (#6026)

* Update changelog

* Fix pervasive test issue with editor properties (#6100) (#6106)

* update version to 2021.6.99 to be able to filter (#6122)

* update version to 2021.6.99 to be able to filter
update changelog

* update package lock and VSCode api

* don

* remove api changes in the code

* Port Don's fixes (#6115)

* Fix test failures resulting from VSCodes Notebook Start page (#6111)

* Disable kernel auto startup in untrusted workspace (#6088)

* Disable kernel auto startup in untrusted workspace

* Fixes

* Misc

* oops

* misc

* Fixes to breaking tests (#6074)

Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>

* Breaking changes ports to release (2 commits) (#6140)

* add component governance file (#6166)

* add component governance file

* remove npm components

* Cherry pick changes from main branch into release (#6174)

* final update (#6176)

* final update

* update changelog

* add missing thanks to changelog (#6197)

* Skip uploading vsix to azure blob store (#6204)

* publish release

* publish release

* remove last 2 numbers from release (#6219)

* publish release

* Do not activate Python before opening nb (#6201) (#6230)

* publish release

* Port LiveKernelModel fix to release for point release (#6264)

* Port keybinding updates to release (#6268)

* Contribute shift+enter, ctrl+enter, L, shift+L (#6205)

* Ctrl+Enter should put cell into command mode after executing (#6231)

* Update CHANGELOG and remove news

* port test fix (#6275)

* Fix Restarting kernel... test (#6267)

* wait for the restart command

* add news file

* update changelog

* Fix native notebook interrupt toolbar (#6280) (#6282)

* update changelog (#6284)

* -update version
-update changelog

* leave version as it was

* Respect jupyter.enableKeyboardShortcuts setting and enable ctrl+enter in command mode (#6293)

* publish release

* fix gulpfile

* undo change

Co-authored-by: Ian Huff <ianhu@microsoft.com>
Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com>
Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyceerhl joyceerhl joyceerhl approved these changes

@DavidKutu DavidKutu DavidKutu approved these changes

@rchiodo rchiodo rchiodo approved these changes

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DonJayamanne @codecov-commenter @IanMatthewHuff @rchiodo @DavidKutu @joyceerhl