NPM Errors When Building from source #7936
Conversation
|
Weird, i'm not running into any issues, no issues on CI either. |
| @@ -24,7 +24,8 @@ | |||
| "noUnusedLocals": true, | |||
| "noUnusedParameters": true, | |||
| "noFallthroughCasesInSwitch": true, | |||
| "useUnknownInCatchVariables": false | |||
| "useUnknownInCatchVariables": false, | |||
| "skipLibCheck": true | |||
There was a problem hiding this comment.
Yeah we really don't want to do this. This skips all type checking. What errors are you getting?
There was a problem hiding this comment.
@DonJayamanne @rchiodo this issue was logged here (I was just taking a peek at it myself at the end of the day on Thursday) #7935. I can actually repro it with npm run build-ipywidgets and you can see the error.
I checked on the Jupyterlab gitter and it looks like it's introduced with TypeScript 4.4. I agree that we don't want to just skipLibCheck though.
There was a problem hiding this comment.
Might be the removal of ClientRect in 4.4? microsoft/TypeScript-DOM-lib-generator#1029 (comment)
There was a problem hiding this comment.
Weird I'm not running into this, let me delete everything and try again. I used to get these but not anymore.
Please ensure your address using the right version of node 14.16.0 and npm 6.
There was a problem hiding this comment.
I'll check my versions, but the issue (to me) didn't look node specific.
Here is JupyterLab (in progress) updating it for 4.4 support. jupyterlab/jupyterlab@ce2b2be
There was a problem hiding this comment.
@DonJayamanne does the npm run command that I showed not repro it for you?
There was a problem hiding this comment.
I created a new PR here that I think has the more specific fixup that we need. Added thanks to ChaseKnowlden in that PR for finding the issue and getting the fix rolling.
|
Closing this PR as th eoriginal issue has been resolved |
For #7935
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).