Jupyter editor types fix for ipywidget build #7942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
DonJayamanne
approved these changes
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #7942 +/- ##
=====================================
Coverage 70% 70%
=====================================
Files 364 364
Lines 22427 22427
Branches 3416 3416
=====================================
Hits 15882 15882
+ Misses 5171 5160 -11
- Partials 1374 1385 +11
|
rchiodo
reviewed
Oct 15, 2021
| @@ -19,8 +19,10 @@ function ignoreTypescript4File(relativePath, searchString) { | |||
| while (fileContents[searchIndex] != '\n') { | |||
| searchIndex--; | |||
| } | |||
| const newFileContents = `${fileContents.substr(0, searchIndex+1)}\n// @ts-ignore\n${fileContents.substr(searchIndex+1)}`; | |||
| fs.writeFileSync(filePath, newFileContents, {encoding: 'utf-8'}); | |||
| const newFileContents = `${fileContents.substr(0, searchIndex + 1)}\n// @ts-ignore\n${fileContents.substr( | |||
There was a problem hiding this comment.
This change seems unnecessary? It's just spacing?
There was a problem hiding this comment.
Probably via the linter/formatter
There was a problem hiding this comment.
@rchiodo that was just prettier formatting the file. Figured that I should keep it formatted in the PR.
rchiodo
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7935
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).