-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed Notebook creation from extension since it is moving to built-in #9311
Conversation
Thats not true, if you open a julia notebook and use that, then the new notebook created using that command defaults to Julia. |
That happens through controller selection for the created notebook, not the notebook creation itself. This change should not affect that behavior, although I'm having a hard time testing that in OSS. |
Yeah looking at the old code, it never worked, looks like the code was lost at some point. |
05aba4f
to
62010e4
Compare
Codecov Report
@@ Coverage Diff @@
## main #9311 +/- ##
=====================================
Coverage 74% 74%
=====================================
Files 219 219
Lines 10919 10919
Branches 1512 1512
=====================================
+ Hits 8153 8183 +30
+ Misses 2176 2138 -38
- Partials 590 598 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must change the engine in package.json (to 1.65-insider
) to ensure this change goes out ONLY with the corresponding 1.65 version of VS Code.
Fixes #9250
This should be merged in coordination with microsoft/vscode#144789 to limit the amount of time that the command is unavailable/duplicated.
The create Notebook flow is still used pretty widely in the test framework, so this change does not completely remove it.
This will remove the functionality of registered 3rd party notebooks appearing in the "Create Jupyter Notebook" quick pick menu since that command will simply create a Python Notebook.
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).