Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include 'create notebook' in the command pallette #144789

Merged
merged 1 commit into from
Mar 15, 2022
Merged

include 'create notebook' in the command pallette #144789

merged 1 commit into from
Mar 15, 2022

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Mar 9, 2022

Part of microsoft/vscode-jupyter#9250 and should be coordinated with the related PR in the Jupyter extension.

  • The short title is used in the "new file..." menu, this is how the jupyter extension was adding the commands.
  • I added the category "Create" to be consistent with Create: New File... so that it reads Create: New Jupyter Notebook

@amunger amunger mentioned this pull request Mar 9, 2022
Merged
9 tasks
@amunger amunger marked this pull request as ready for review March 15, 2022 17:07
@amunger amunger requested a review from rebornix March 15, 2022 17:08
rebornix
rebornix approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amunger amunger merged commit 70182c0 into microsoft:main Mar 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@amunger amunger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amunger @rebornix