Use client ID as fallback for diagnostics collection #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the language client ID as a fallback for the diagnostics collection name. If no collection name is provided, VSCode generates one. This name is visible in the diagnostics table view of the problems panel.
|
Makes sense. When we started we didn't have a table problems view :-) |
|
@dbaeumer Friendly ping. I read your comment as you finding this a good idea. I think it makes sense to include this in v10, which is in alpha now. |
|
@remcohaszing still agree that this is a good a change. Could you make the code adjustment I asked for. |
|
I don’t see any review comments. Did you maybe forget to press Submit? 😅 |
dbaeumer
requested changes
Jun 28, 2024
client/src/common/client.ts
Outdated
| this._diagnostics = this._clientOptions.diagnosticCollectionName | ||
| ? Languages.createDiagnosticCollection(this._clientOptions.diagnosticCollectionName) | ||
| : Languages.createDiagnosticCollection(); | ||
| this._diagnostics = Languages.createDiagnosticCollection(this._clientOptions.diagnosticCollectionName || this._id); |
There was a problem hiding this comment.
Can we make this this._clientOptions.diagnosticCollectionName ?? this._id
|
Did not press the button. |
This means the name can be set to an empty string.
dbaeumer
approved these changes
Jun 28, 2024
Tyriar
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the language client ID as a fallback for the diagnostics collection name. If no collection name is provided, VSCode generates one. This name is visible in the diagnostics table view of the problems panel.
This can be solved for every language server integration separately, but IMO it’s nicer if this package provides a better default. An alternative is to use the name instead of the ID. I went with ID, because
typescriptin the screenshot is lower case.