Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use client ID as fallback for diagnostics collection #1445

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Use client ID as fallback for diagnostics collection #1445

merged 3 commits into from
Jun 28, 2024

Commits on Mar 7, 2024

  1. Use client ID as fallback for diagnostics collection 

    This sets the language client ID as a fallback for the diagnostics
collection name. If no collection name is provided, VSCode generates
one. This name is visible in the diagnostics table view of the problems
panel.
    @remcohaszing
    remcohaszing committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9011646 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Merge branch 'main' into diagnostics-collection-name-fallback

    @dbaeumer
    dbaeumer committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1d0a0ba View commit details
    Browse the repository at this point in the history

  2. Use nullish coalescing to fallback to the id 

    This means the name can be set to an empty string.
    @remcohaszing
    remcohaszing committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    88b7f90 View commit details
    Browse the repository at this point in the history