-
Notifications
You must be signed in to change notification settings - Fork 38
Spell check not working #54
Comments
No sounds like you are following the right steps - seams odd however - I'll have a look to see if I can repro. |
Since I have updated VSCode to 1.6.1 is failing also to me. ¿Any idea about how to debug this? |
Same with me german works, but en does nothing. VSCode 1.6.1
|
OK I think I have an idea on the issue. - I had a similar repro I'm not processing some char the right way and crashing (it may well be a change in the engine). Any chance you can send me the file you used. You can share privately via sean @ mcbreen.co.nz. |
Just any text.
In spanish detects mundlo as wrong word.
In english there are no messages. |
Same here. Code 1.6.1. Nothing, not even in Spanish. Fresh markdown file. |
Devtool reports this error
It seems like the public provideCodeActions(...): vscode.Command[] {
let diagnostic: vscode.Diagnostic = context.diagnostics[0];
let match: string[] = diagnostic.message.match(/\[([a-zA-Z0-9\ ]+)\]\ \-/); Maybe something is changed about retrieving diagnostics from the context. |
A quick update - the issue appears to be upstream in the service. I've not yet isolated it but for english it simply returns no results whereas it returns results for other languages as pointed out above. I'll keep digging into it. |
OK definitely at the service level - I have a very cut down test that returns nothing for the English end-point but returns as expected for German. Here is the relevant code: function postHTTP() {
var request = require('request');
var content = "loook";
var key = "6dbf22d9ba22f882d017896a1fc0e978a106bed0";
var enURL = "https://en.service.afterthedeadline.com/checkDocument"
var deURL = "https://de.service.afterthedeadline.com/checkDocument"
request({ method: "POST", url: enURL, form: { data: content, key: key } },
function (error, response, body) {
console.log(">>>>English Results>>>>>");
console.log(body);
}
);
request({ method: "POST", url: deURL, form: { data: content, key: key } },
function (error, response, body) {
console.log(">>>>German Results:>>>>");
console.log(body);
}
);
} The console gets the following results...
As you can see in the code the body is 100% the same. I think the best next step is to ask the service owners if something is up on there end. |
Looks like the google group associated with 'afterthedeadline' is pretty dead: https://groups.google.com/forum/#!forum/atd-developers. Hopefully you hear back from them. (I'm getting the same issue) |
I can confirm the issue on VS Code 1.7.1. For reference, here is my {
"language": "en",
"ignoreWordsList": [
"vscode",
"Markdown",
"config",
"languageIDs",
"alefragnani",
"Config",
"json",
"ignoreWordsList",
"ignoreRegExp",
"mistakeTypeToStatus",
"markdown",
"excludeFilesList",
"emph"
],
"mistakeTypeToStatus": {
"Passive voice": "Hint",
"Spelling": "Error",
"Complex Expression": "Warning",
"Hidden Verbs": "Information",
"Hyphen Required": "Error",
"Redundant Expression": "Information",
"Did you mean...": "Information",
"Repeated Word": "Error",
"Missing apostrophe": "Error",
"Cliches": "Warning",
"Missing Word": "Warning",
"Make I uppercase": "Warning"
},
"languageIDs": [
"markdown",
"latex",
"plaintext"
],
"ignoreRegExp": [
"/`(kb.*?)`/g",
"/(http\\\\S*)/gm",
"/\\\\(.*.png\\\\)/g",
"/\\\\(.*.gif\\\\)/g",
"/\\\\(.*.md\\\\)/g",
"/\\\\(.*.jpg\\\\)/g",
"/^((`{3}\\\\s*)(\\\\w+)?(\\\\s*([\\\\w\\\\W]+?)\\\\n*)\\\\2)\\\\n*(?:[^\\\\S\\\\w\\\\s]|$)/gm"
]
} |
There is a Pull Request for teacher module that should fix this issue: vesln/teacher#9 |
@dwonisch thanks for pointing this out and sorry it took me so long to see this (I was on holiday last week). I've removed the dependency on So a new version of the extension is published - it should work - although I think some of the other URIs are failing e.g. in testing DE was only workign 50% of the tine - the rest of the time I got a Thank you. It would be great if you guys could try it out and see if it's working for you. |
Thank you, it is working again :) Awesome work I found out that the Demo of AtD is using a different URL in it's POST requests http://www.polishmywriting.com/ Although I'm not the creator of that PR in teacher repo, looks like someone else figured that out before me. |
Seems that German Language is broken now in 0.9.0 and 0.9.1 |
Yes I think it's the service unfortunately - my test harness also fails for de now (whereas it worked until today).
Lets hope it comes back tomorrow. |
I can confirm even the new URI is not consistently working.
There is an interesting PR to allow users to leverage a local AtD server via a setting described here #59. I probably can't review this today but will look into it - however I fell it will probably not resolve the issues for everyone - as most people will not have there own server. Sean |
The same error happens or not randomly if you write the text directly in the input box of http://www.polishmywriting.com/ and then click "Check Writing". |
1.9.0-insider - spell checking hasn't worked in any language for a couple of weeks now. Anything I can do to help debug? |
I'm afraid the service we use is dead - there really is no work around. My current thought is to deprecate the extension and suggest people use: https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker Sorry :( |
It still doesn't work (OSX VSCode 1.9.1):
|
It's a good suggestion and I just checked http://wiki.languagetool.org/public-http-api. It looks encouraging - however - there are no guarantees, limited access via IP and it's still via HTTPs. I recently reached out to: streetsidesoftware/vscode-spell-checker#69 to suggest I send users there. That implementation uses local logic and as a result won;t have the same outages. It does not support non-English checking or grammar however unfortunately. Sean |
This extension has had a large number of stability issues based on the availability of the underlying service. Today I published an update which points users to another extension for Spell Checking. I'm closing the majority of issues as development on the extension has stopped. Sorry for any inconvenience this caused anyone, the good news is that there are better options out there now that don't require the service. Sean |
Hi,
I just installed the package and it doesn't seem to work for me.
I have the default spell.json in the .vscode folder, markdown and plaintext enabled. Didn't work for a few minutes. I deleted a file in .vscode, then it worked for a few minutes. I added a few words to the ignoreWordsList by clicking "Ignore word" (or similar).
Now it stopped working again and I cannot get it to work. Connection to internet is available. The "Problems" panel is empty.
Am I missing sth?
Thanks
The text was updated successfully, but these errors were encountered: