Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: SVGs can't be used as icons #181

Closed
yzhang-gh opened this issue Jun 24, 2017 · 5 comments
Closed

Error: SVGs can't be used as icons #181

yzhang-gh opened this issue Jun 24, 2017 · 5 comments

Comments

@yzhang-gh
Copy link

yzhang-gh commented Jun 24, 2017

After upgrade from 1.22 to 1.26, it says that

Error: SVGs can't be used as icons: images/foo.svg

I think at least there should be a notice since it is a 'breaking' change. Which kind of icon is supported? Which size is it should be?

@xconverge
Copy link

It looks like this:

7cf67dd

I have the problem of a slack badge now is a non trusted source

@eamodio
Copy link
Contributor

eamodio commented Jun 25, 2017

I'm running into the same -- why was this changed?

@joaomoreno
Copy link
Member

Changes are indeed coming on the SVG support in the Marketplace. More information in the upcoming release notes: https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_14.md#changes-for-extension-authors

henryju added a commit to SonarSource/sonarlint-vscode that referenced this issue Jun 26, 2017
henryju added a commit to SonarSource/sonarlint-vscode that referenced this issue Jun 26, 2017
@eamodio
Copy link
Contributor

eamodio commented Jun 26, 2017

@joaomoreno does that mean that extensions can't have any SVG resources? Or only in the marketplace resources?

@joaomoreno
Copy link
Member

Only in the Marketplace resources. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants