-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: SVGs cannot be used as icons #183
Comments
I am experiencing that issue as well. The message looks like it's intentional though ( |
yeah, especially since
|
So this commit is responsible, somebody asked why and got no answer =/ |
The same answer from #181: Changes are indeed coming about SVG support in the Marketplace. More information in the upcoming release notes: https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_14.md#changes-for-extension-authors It's a sad restriction but a necessary one. |
Instead of throwing an error, how about silently converting the SVG to a PNG with https://www.npmjs.com/package/svg-to-png? |
Hey... github actions generates a svg badge and there is no way to get a PNG badge: Can't we support at least badges as svgs, or convert, or just ignore them instead of the error (I don't care a lot for a build sucess badge on the store page but I do care about it on my project repo)? Otherwise I can't see how to cleanly interop github actions and vscode... |
@luanpotter same here. This is still not fixed. I can't add GH Actions badge because it's SVG :/ |
The VS Marketplace now has an open issue tracker, feel free to submit this feature request over there: https://github.com/microsoft/vsmarketplace |
Is |
See [microsoft/vscode-vsce #183](microsoft/vscode-vsce#183)
Just wanted to a release a new version of PHP IntelliSense, but the build broke:
https://travis-ci.org/felixfbecker/vscode-php-intellisense/builds/247593000#L917
I have been using an SVG as an icon forever and that has always worked fine:
https://marketplace.visualstudio.com/items?itemName=felixfbecker.php-intellisense
The text was updated successfully, but these errors were encountered: