Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ignore npm package instead of custom code for .vscodeignore #418

Merged
merged 2 commits into from
Jun 4, 2021
Merged

use ignore npm package instead of custom code for .vscodeignore #418

merged 2 commits into from
Jun 4, 2021

Conversation

jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Jan 31, 2020 •
edited
Loading

fix #417

ignore implements the .gitignore spec and is very thoroughly tested...best to outsource this logic

@jedwards1211 jedwards1211 changed the title use ignore npm package instead of half-baked custom code for .vscodeignore use ignore npm package instead of custom code for .vscodeignore Jan 31, 2020
@joaomoreno joaomoreno self-assigned this Feb 3, 2020
@sebas2day sebas2day mentioned this pull request Aug 24, 2020
Closed
@joaomoreno joaomoreno mentioned this pull request Sep 30, 2020
Merged
Base automatically changed from master to main February 10, 2021 14:44
@joaomoreno joaomoreno merged commit 57b293e into microsoft:main Jun 4, 2021
@joaomoreno
Copy link
Member

Sorry for the attrocious delay! Thanks! 🍻

@joaomoreno joaomoreno added this to the May 2021 milestone Jun 4, 2021
@joaomoreno joaomoreno mentioned this pull request Jun 7, 2021
Closed
@robertoaloi robertoaloi mentioned this pull request Jun 11, 2021
Merged
@Vtec234 Vtec234 mentioned this pull request Jun 25, 2021
Closed
@joaomoreno joaomoreno mentioned this pull request Jun 25, 2021
Closed
3 tasks
@alefragnani alefragnani mentioned this pull request Sep 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
May 2021
2 participants
@jedwards1211 @joaomoreno