Revert changes ignore file semantic

[joaomoreno]

In #418 we fixed #417 by adopting npm's ignore module for our .vscodeignore semantics. This actually broke a lot of extensions:

• vsce@1.92.0 breaks my (admittedly weird) .vscodeignore configuration #576
• vsce package on marketplace different than when building a package #583
• icon location broken in 1.92.0 and later #584
• Versions after (i think) 1.80.0 break build of Prettier extension #585
• VSCE not honoring .vscodeignore exclusions correctly #587

Semantic differences

It used to be possible to write such a rule:

node_modules
!node_modules/highlight.js/styles

With npm's ignore module, we're force to do this instead:

node_modules/*
!node_modules/highlight.js
node_modules/highlight.js/*
!node_modules/highlight.js/styles

Plan

Apart from being a breaking change, I argue this is a change in behavior for the worse. For those two reasons, I propose to simply revert the change for 1.95.0.

• Revert change
• Write test cases which lock us in our semantics for future changes
• Create PRs to revert the damage done

Sorry

Finally, thanks all for the patience and the persistence in filling issues. I apologise for my stubborness. We should've caught this early on and optimized for compatibility. 🙇‍♂️

cc @aeschli @Pustur @fyangstudio @larshp @kitsonk @Timmmm @juli1 @orph @GordonSmith @ntotten @PeterWone

[GordonSmith]

@joaomoreno any thoughts on simply supporting the "files" section in package.json to specify which files should go into the vsix?

[joaomoreno]

No thoughts.

[larshp]

note this change was published in 1.95.0

[Timmmm]

@joaomoreno any thoughts on simply supporting the "files" section in package.json to specify which files should go into the vsix?

I agree that would be more intuitive. Definitely feels weird for everything to be published by default!