Revert .vscodeignore changes #2004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6fb91c3.
joaomoreno
changed the title
|
Thanks for the heads up. According to #1983 (review) , our changes should be able to support both, which would be better, but I'll verify. |
|
@rgrunber Yeah at a glance I believe your solution does support both implementations. |
|
I've confirmed vsce ls output is identical for local builds before and after. DONE Packaged: java-0.80.0-255.vsix (113 files, 45.83MB) I would probably close this out for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info: microsoft/vscode-vsce#588