Fix .vscodeignore #2017
Closed
Fix .vscodeignore #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntotten
reviewed
Jun 22, 2021
This removes the forced version of vsce added in df6978b
|
I was about to create exactly the same PR. Thanks @tjquillan. |
|
This isn't needed any more, please close it. More info: microsoft/vscode-vsce#588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address the problems that occurred in #2013 and #2016. The root cause I believe is microsoft/vscode-vsce#576 where vsce changed how it parses .vscodeignore. This PR changes it so
node_modules/prettieris once again included.Side note:
I would like to use this PR to add some additional things that I am unsure of their necessity in the final bundle. I will list these below.
.husky/.nvmrcCHANGELOG.mdwith a summary of your changes