-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make module context-aware #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests that uses the module simultaneously from main thread as well as nodejs worker threads
appveyor.yml
Outdated
@@ -7,6 +7,7 @@ environment: | |||
- nodejs_version: "10" | |||
- nodejs_version: "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove 10 and 11, they're pretty old at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 for the test
@Tyriar appveyor is not running on this repo due to permission issues https://ci.appveyor.com/project/Tyriar/vscode-windows-process-tree/builds/38563417, can you reauthorize. Thanks! |
Fixed it |
I'll go change the tests because the current worker tests don't call into native code. |
Additionally can you add a test that checks the memory usage of the process, use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just keep node 12 and 14 in appveyor.yml
I didn't add the memory leak test because the delta between the initial memory and final memory amounts, even after enabling GC (by passing |
Ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very thorough 🙂
Fixes microsoft/vscode#120570