Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows-process-tree needs to be context-aware #120570

Closed
rzhao271 opened this issue Apr 5, 2021 · 4 comments · Fixed by microsoft/vscode-windows-process-tree#30
Closed

windows-process-tree needs to be context-aware #120570

rzhao271 opened this issue Apr 5, 2021 · 4 comments · Fixed by microsoft/vscode-windows-process-tree#30
Assignees
@rzhao271
Labels
debt Code quality issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes sandbox Running VSCode in a node-free environment verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2021

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Apr 5, 2021

See #120431 (comment)

We need to make https://github.com/microsoft/vscode-windows-process-tree context-aware.
@rzhao271 rzhao271 added feature-request Request for new features or functionality debt Code quality issues sandbox Running VSCode in a node-free environment labels Apr 5, 2021
@rzhao271 rzhao271 added this to the April 2021 milestone Apr 5, 2021
@rzhao271 rzhao271 self-assigned this Apr 5, 2021
rzhao271 added a commit to microsoft/vscode-windows-process-tree that referenced this issue Apr 5, 2021
@rzhao271
Make context-aware, fixes microsoft/vscode#120570
fb0f21f
@rzhao271 rzhao271 mentioned this issue Apr 5, 2021
Merged
@kieferrm kieferrm mentioned this issue Apr 5, 2021
Closed
75 tasks
rzhao271 added a commit to microsoft/vscode-windows-process-tree that referenced this issue Apr 8, 2021
@rzhao271
Make module context-aware (#30)
767e74e 
Fixes microsoft/vscode#120570
rzhao271 added a commit that referenced this issue Apr 9, 2021
@rzhao271
Bump windows-process-tree, fixes #120570
46feb94
@rzhao271 rzhao271 added verification-needed Verification of issue is requested on-release-notes Issue/pull request mentioned in release notes labels Apr 26, 2021
@rzhao271
Copy link
Contributor Author

rzhao271 commented Apr 27, 2021 •
edited
Loading

To verify: code review, or clone the vscode-windows-process-tree repo and ensure tests pass locally.

@bpasero
Copy link
Member

bpasero commented Apr 28, 2021

@rzhao271 see microsoft/vscode-windows-process-tree#31 which is a PR to add automated GH action to run tests on Windows.

@bpasero
Copy link
Member

bpasero commented Apr 28, 2021

Oh, only now I saw appveyor was already setup to run the tests, but then I think this is verified?

@rzhao271
Copy link
Contributor Author

Yeah it's a weird case. The CI did already verify it, then, and the PR was reviewed anyway.
Marking this as verified, especially since only the ptyHost (under the shared process) and main process use this module, and neither of them are affected by the process render reuse branch 🤷

@rzhao271 rzhao271 added the verified Verification succeeded label Apr 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
debt Code quality issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes sandbox Running VSCode in a node-free environment verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

Successfully merging a pull request may close this issue.

Make module context-aware microsoft/vscode-windows-process-tree
2 participants
@bpasero @rzhao271