Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows CI with test run #31

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Add Windows CI with test run #31

merged 3 commits into from
Apr 28, 2021

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Apr 28, 2021

No description provided.

@bpasero bpasero mentioned this pull request Apr 28, 2021
Closed
Tyriar
Tyriar reviewed Apr 28, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to remove appveyor as well

@bpasero
Copy link
Member Author

bpasero commented Apr 28, 2021

Good point, pushed.

rzhao271
rzhao271 requested changes Apr 28, 2021
View reviewed changes
.github/workflows/node.js.yml Outdated Show resolved Hide resolved
rzhao271
rzhao271 approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpasero bpasero merged commit 009e018 into main Apr 28, 2021
@bpasero bpasero deleted the ben/ci branch April 28, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar left review comments

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpasero @Tyriar @rzhao271