Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings editor rendering breaks for objects with null default values #101637

Closed
RMacfarlane opened this issue Jul 2, 2020 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@RMacfarlane
Copy link
Contributor

Issue Type: Bug

  1. Install Azure Account extension

  2. Open settings GUI and search for Azure. The ppe setting seems to break rendering, the GUI becomes blank
    Screen Shot 2020-07-02 at 3 28 04 PM

  3. Close and try to reopen settings, get
    Screen Shot 2020-07-02 at 3 29 24 PM

The azure.ppe setting:

        "azure.ppe": {
          "type": "object",
          "properties": {
            "portalUrl": {
              "type": "string"
            },
            "publishingProfileUrl": {
              "type": "string"
            },
            "managementEndpointUrl": {
              "type": "string"
            },
            "resourceManagerEndpointUrl": {
              "type": "string"
            },
            "sqlManagementEndpointUrl": {
              "type": "string"
            },
            "sqlServerHostnameSuffix": {
              "type": "string"
            },
            "galleryEndpointUrl": {
              "type": "string"
            },
            "activeDirectoryEndpointUrl": {
              "type": "string"
            },
            "activeDirectoryResourceId": {
              "type": "string"
            },
            "activeDirectoryGraphResourceId": {
              "type": "string"
            },
            "batchResourceId": {
              "type": "string"
            },
            "activeDirectoryGraphApiVersion": {
              "type": "string"
            },
            "storageEndpointSuffix": {
              "type": "string"
            },
            "keyVaultDnsSuffix": {
              "type": "string"
            },
            "azureDataLakeStoreFileSystemEndpointSuffix": {
              "type": "string"
            },
            "azureDataLakeAnalyticsCatalogAndJobEndpointSuffix": {
              "type": "string"
            },
            "validateAuthority": {
              "type": "boolean"
            }
          },
          "default": null,
          "description": "Development setting: The PPE environment for testing."
        }

VS Code version: Code - Insiders 1.47.0-insider (04545fa, 2020-07-02T05:41:12.081Z)
OS version: Darwin x64 18.7.0

@9at8
Copy link
Member

9at8 commented Jul 5, 2020

Good catch!

@RMacfarlane RMacfarlane added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Jul 6, 2020
@9at8
Copy link
Member

9at8 commented Jul 6, 2020

@RMacfarlane null is actually not the correct default value type. If you want to allow null as valid type, then the type should be ["object", "null"].

@RMacfarlane RMacfarlane added this to the June 2020 milestone Jul 6, 2020
@RMacfarlane
Copy link
Contributor Author

Since we don't enforce this and it causes the UI to break, I think we should try to get this fix in before the next release.

I'll update the Azure Account extension, though.

9at8 pushed a commit that referenced this issue Jul 6, 2020
@9at8 9at8 closed this as completed Jul 6, 2020
@9at8 9at8 added awaiting-insiders-release settings-editor VS Code settings editor issues labels Jul 6, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Jul 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants