Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings Editor] Correctly handle null default values for objects #101807

Merged
merged 1 commit into from
Jul 6, 2020
Merged

[Settings Editor] Correctly handle null default values for objects #101807

merged 1 commit into from
Jul 6, 2020

Conversation

9at8
Copy link
Member

@9at8 9at8 commented Jul 6, 2020

Fixes #101637

  1. Install https://marketplace.visualstudio.com/items?itemName=ms-vscode.azure-account
  2. Go to azure.ppe setting.
  3. No notifications are shown, and UI doesn't break down.

@9at8 9at8 added this to the June 2020 milestone Jul 6, 2020
@9at8 9at8 requested a review from roblourens July 6, 2020 16:48
@9at8 9at8 changed the title Correctly handle null default values for objects [Settings Editor] Correctly handle null default values for objects Jul 6, 2020
@9at8 9at8 merged commit de70a4e into release/1.47 Jul 6, 2020
@9at8 9at8 deleted the adi/correctly-handle-null-values branch July 6, 2020 23:11
9at8 added a commit that referenced this pull request Jul 6, 2020
@9at8
Correctly handle null default values for objects (#101807)
440c1c4 
Fixes #101637
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this pull request Jul 8, 2020
@9at8 @gjsjohnmurray
Correctly handle null default values for objects (microsoft#101807)
c35b510 
Fixes microsoft#101637
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@9at8 @roblourens