-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stablize apple silicon exploration builds #106770
Comments
|
Above crash is most likely fixed by https://chromium-review.googlesource.com/c/v8/v8/+/2378307 , need to confirm. |
Wasm modules doesn't load with cross-compiled mac arm64 version, reported upstream at https://bugs.chromium.org/p/chromium/issues/detail?id=1150060 |
This issue on Node, nodejs/node#36160, points to this merged PR as a potential fix for wasm module loading failure nodejs/node#35986. The PR cherry-picks some changes from v8 upstream. The changes from the PR have not landed in a Node release yet, however, as of v15.2.1. |
Thanks for looking into it, the electron version we ship for the exploration build also carries those patches. The problem is that those changes are behind V8_HOST_ARCH_ARM64 macro and the electron releases are currently cross-compiled, hence I have opened the chromium issue to investigate fix for cross-compiled builds. |
Upstream issue clarified about the usage of |
@deepak1556 Electron has released v11.0.3. https://www.electronjs.org/releases/stable#11.0.3 Although it's not in the release notes, it contains the commit that rolls back the darwin-arm64 patches that were deemed unnecessary by upstream Chromium. Should be testable in a build of VSCode now. |
slightly off topic: cpptools and live-share do not appear to work:
I think the teams might already be working on those so I'll just note it here instead of opening issues everywhere for now
|
Our ci was having some trouble for the past 2 days, so builds have been delayed. But good news, latest release based on The final bit left to promote the exploration build to insiders is depending on availability of internal electron arm64 builds. |
I ran into the same issue with the build here. #111072 |
@exiadbq the issue is fixed with latest builds with commit |
@deepak1556 Is there any tracking issue to track the progress on Microsoft-internal Electron arm64 builds? |
There is no separate public issue, all updates will be posted here. |
I have another friend with a M1 mac, and he does not have any issue opening the app downloaded from the insider page. It's just me... Thanks for chiming in guys! Much appreciated! I will just wait for a new build. |
I was having the same problem as @ngocphamm which seems to be from having an Intel insiders build and then switching to a ARM one. After removing all of the cache and pref files for insiders, it started up correctly. When it did fail to start, it dis leave this in the system.log:
I was perhaps a bit heavy handed in removing prefs so unsure which was the culprit:
|
I think the issue was probably that they accidentally downloaded the intel version, or something went wrong on the site, nice that's its resolved now |
Yep this is the issue. Thanks @nathanhruby. I don't even remember I downloaded and ran the Intel version first. |
@deepak1556 Is it possible to check the previous preferences directories on a new install of the ARM version and either purge them or warn the user to delete them if they contain any Intel-specific info? Is there even any way to tell if the Library files were created from an Intel or an ARM version of VSCode? |
I'm still not quite following. This older link works: https://az764295.vo.msecnd.net/insider/96b426ef1da0f0a51ce9ef1931cd1fd2322547e4/VSCode-darwin-arm64.zip Upgrading it causes it to crash. Removing all the directories @nathanhruby recommends even though I just had the stable Intel version installed and installing from this link: https://code.visualstudio.com/insiders/ I did have the Intel version(stable version not insider) but I moved into Trash can as well. From product.json
From system.log:
|
That older version is what is working. I cannot get the new version to work even after
I just repeated the steps to make sure it was as clean an install as possible.
Hopefully that can help to troubleshoot. |
When you move something to the trash, it only moves the binaries, all the user data and other stuff will still be in the system looks like you left some residual from the intel one so it didn’t reinstall the files, and may have deleted some opengl file hat vscode is missing. There are some tools (like cleanmymacx) that allows you to delete all the files from the app, maybe try something like that? |
@shaunsingh if this is true then how come the older commit is working from 12/14? Also one was a different package since it's stable version and the other one was Insider version. Anyway I still think this is a bug. The user should not have to know about path collisions. One is Intel stable version and the other is M1 Insider edition. |
I recommend the free AppCleaner: |
In that case, it shouldn’t be an issue because iirc stable and insider versions can coexist, are you sure you didn’t install the intel insiders version? |
Ah you are right. I must have installed it first and forgot. 🤦 I went ahead and reinstalled the x86 Insiders Edition used AppCleaner and reinstalled M1 Insiders Edition and it works now. I did |
I too had to use appcleaner to be able to use the arm64 insiders build today |
Sorry about the startup crash, it arises from that fact v8 cache data written by intel app is not readable by the arm version. You can start the app with |
Apple silicon builds will be pushed to stable with upcoming As end user you shouldn't observe any changes when installing the universal stable build app on your apple silicon device, everything should just work even if you had previously been running the intel version. We won't push universal app as an update to your existing |
@deepak1556 Is there an anticipated timeline for when 1.53 will be out or somewhere I can track progress towards that? |
Unfortunately I believe an macOS 11.2 is RC3 and will land any day now. This problem also occurs in VSCode Insiders on macOS 11.2 betas as per #113410 (comment) |
Since my last comment 3 hours ago, Apple released macOS 11.2, with the same build number as RC3. |
Apple silicon stable release will be delayed for another iteration to accommodate the fix for #115646, sorry all! |
hi, I downloaded 1.53 stable and it is intel x64 not arm64. so back to insiders edition for me. please can you update the website, as 1.53 is not arm64 just yet. |
as the previous comment before yours said, arm64 builds have been delayed to the next release. I don't see a mention of arm64 on the stable download site. |
Umbrella issue:
Build to use: https://code.visualstudio.com/insiders/
Any other issues that might come in from testing, should be added to the above list.
The text was updated successfully, but these errors were encountered: