Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate node code cache on apple silicon #113852

Closed
deepak1556 opened this issue Jan 5, 2021 · 2 comments
Closed

Isolate node code cache on apple silicon #113852

deepak1556 opened this issue Jan 5, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Milestone

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Jan 5, 2021

Steps to repro:

  • Install and run x64 version on M1
  • Install and override x64 with arm64
  • Crash on startup in v8 when trying to read the CachedData

Workaround:

Start the app with --no-cached-data

Proposed solution:

Split out the cache data with arch prefix CachedData-x64 , CachedData-arm64

@deepak1556 deepak1556 added 🍎 si bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues labels Jan 5, 2021
@deepak1556 deepak1556 added this to the January 2021 milestone Jan 5, 2021
@jrieken
Copy link
Member

jrieken commented Jan 6, 2021

code pointer:

return path.join(userDataPath, 'CachedData', commit);

jrieken added a commit that referenced this issue Jan 6, 2021
jrieken added a commit that referenced this issue Jan 7, 2021
jrieken added a commit that referenced this issue Jan 7, 2021
jrieken added a commit that referenced this issue Jan 7, 2021
jrieken added a commit to microsoft/vscode-loader that referenced this issue Jan 7, 2021
@jrieken
Copy link
Member

jrieken commented Jan 7, 2021

This is now fixed. The root directory is still CachedData but the individual hash each cache file uses considers now the arch as well. Keeping the root directly the same helps with the cached data cleaning

@jrieken jrieken closed this as completed Jan 7, 2021
@deepak1556 deepak1556 added the verified Verification succeeded label Feb 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants