Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve announcement when cursor is added. #118964

Closed
MarcoZehe opened this issue Mar 15, 2021 · 2 comments
Closed

Improve announcement when cursor is added. #118964

MarcoZehe opened this issue Mar 15, 2021 · 2 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Milestone

Comments

@MarcoZehe
Copy link
Contributor

Issue Type: Bug

  1. With NVDA, make a sure you have an empty line below the current one.
  2. Press NVDA+F2 to pass the next key through, then press CTRL+Alt+DownArrow to add a cursor below. If you don't pass the key through, NVDA interprets it as a table navigation command erroneously.
    • Actual behavior: NVDA speaks "Cursor added: 13:1" (or whatever the current line number is).
    • Expected behavior: The numbers could be better formatted. Depending on the synthesizer and the numbers, this could be interpreted as a time stamp. Would be better if it said "Cursor added on line x column y" or similar.

VS Code version: Code - Insiders 1.55.0-insider (84fe402, 2021-03-15T05:14:29.836Z)
OS version: Windows_NT x64 10.0.19042

System Info
Item Value
CPUs AMD Ryzen 9 3900X 12-Core Processor (24 x 3800)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.95GB (20.89GB free)
Process Argv --crash-reporter-id af385ced-002b-4d51-928c-05d733e674ab
Screen Reader yes
VM 40%
Extensions (38)
Extension Author (truncated) Version
npm-intellisense chr 1.3.1
gitignore cod 0.6.0
doxdocgen csc 1.1.0
dart-code Dar 3.20.1
flutter Dar 3.20.0
vscode-markdownlint Dav 0.39.0
vscode-eslint dba 2.1.17
gitlens eam 11.3.0
EditorConfig Edi 0.16.4
vscode-npm-script eg2 0.3.17
prettier-vscode esb 6.2.0
vscode-pull-request-github Git 0.24.0
beautify Hoo 1.5.0
better-cpp-syntax jef 1.15.5
jstl jsx 1.0.4
flutter-intl loc 1.14.0
vscode-docker ms- 1.10.0
vscode-edge-devtools ms- 1.1.4
python ms- 2021.2.636928669
vscode-pylance ms- 2021.3.1
jupyter ms- 2021.4.641214696
remote-containers ms- 0.163.2
remote-ssh ms- 0.65.1
remote-ssh-edit ms- 0.65.1
remote-wsl ms- 0.54.3
cmake-tools ms- 1.6.0
cpptools ms- 1.2.2
cpptools-extension-pack ms- 1.0.0
vscode-github-issue-notebooks ms- 0.0.72
vscode-markdown-notebook ms- 0.0.14
vsliveshare ms- 1.0.3968
vsliveshare-audio ms- 0.1.91
debugger-for-edge msj 1.0.15
indent-report ogo 1.0.0
nunjucks ron 0.3.0
cmake twx 0.0.17
vscode-webhint web 1.5.11
omnipascal Wos 0.18.0

(1 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30263608
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256198
vstry914:30244316
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvsnew554:30265444
pythontb:30258533
vsget980:30265949
vspre833cf:30267465
vsfjg287:30275553

@isidorn isidorn self-assigned this Mar 15, 2021
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues polish Cleanup and polish issue labels Mar 15, 2021
@isidorn isidorn added this to the March 2021 milestone Mar 15, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2021

@MarcoZehe thanks for feedback, we can easily change this. I just went with LINE:COLUMN to be concise.
So let's go with
Cursor added on line x column y

Alternative

Cursor added: line x column y

@MarcoZehe
Copy link
Contributor Author

Either would be fine with me.

lramos15 pushed a commit that referenced this issue Mar 16, 2021
lramos15 pushed a commit that referenced this issue Mar 18, 2021
Fixes #118978

explorerModel: add toString to explorerItem for more precise error message

multicursor aria polish

fixes #118964
fixes #118965

debt - consolidate process usage

:lipstick: process use

fix #118970

accessibility: 1000 page size as default

Do no install repo on Raspberry Pi OS (#118826)

* Do no install repo on Raspberry Pi OS

* 💄

Co-authored-by: João Moreno <joao.moreno@microsoft.com>

firefox: do not use ctrl+shift+P for show all commands since it is taken, make sure F1 is rendered

untitledHint: introduce default for workbench.editor.untitled.hint

better aria label for the remote host status bar item

fixes #118839

Fix #118958

Fix #118953

Remove unused

Remove only

Rename setting gettingStarted.hiddenCategories => workbench.welcomePage.hiddenCategories
Fixes #118990

Don't create markdown previews if cell is in edit mode

unHidePreview should also update dimensions

update seti theme. fixes #118912

test view/model range convertion with hidden cells.

share drag impl for builtin and custom md renderer.

adopt multi select in drag and drop. drag the focus or selection around the focus.

update list item height on markdown cell ctor as we might already warm up the viewport.

Fix border overlap in quick pick UI (#119039)

Fixes #107737

debt - some more process and platform 💄

debt - use product quality instead of probing for name

Adds RemoteHub to api allow list

fix build

mark APIs as deprecated

fix: typo

custom editors - make conflict resolution actions appear (#118949)

Workspace trust changes (#119017)

* Add dialog button customisation and reject promise if cancelled
* Use different promises to modal/soft requests

new debug setting for clearing a terminal before reusing; fixes #116699

Pick up fix for #117054

Update types

Ports: service -> application, defaults ->unconfigured

ignore file events while saving, more logging, #118992

more deprecations

Fix task start firing with invalid process ID in dependsOn task

This was caused by the env var relaunch @debounce decorator that was added to
prevent the process from relaunching multiple times when multiple extensions
contribute to the environment. This caused the reuseTerminal call to not have
the new processReady promise ready immediately after reuseTerminal was called.
The fix which seems safe it to just move the @debounce over to relaunchTerminal
that tasks doesn't use.

Fixes #118256

Fixes #119011: Wait for the vscode API to become available before launching extension tests
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants
@MarcoZehe @isidorn and others