Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will crash after searching at extension panel #177046

Closed
HomyeeKing opened this issue Mar 14, 2023 · 25 comments · Fixed by #218245
Closed

will crash after searching at extension panel #177046

HomyeeKing opened this issue Mar 14, 2023 · 25 comments · Fixed by #218245
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron extensions-editor freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded webview Webview issues
Milestone

Comments

@HomyeeKing
Copy link

HomyeeKing commented Mar 14, 2023

Does this issue occur when all extensions are disabled?: No

I search something at the extension detail page, then switch the tab, vscode got crash and exit

only can reproduce w/ the search operation(command + f), disable all the extension will be fine

Version: 1.76.1 (Universal)
Commit: 5e805b79fcb6ba4c2d23712967df89a089da575b
Date: 2023-03-08T16:32:09.831Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Darwin arm64 22.3.0
Sandboxed: No

Steps to Reproduce:

2023-03-14.14.19.35.mov
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 14, 2023

Please explain what that video is showing

@mjbvz mjbvz added the ~info-needed Issue requires more information from poster (with bot comment) label Mar 14, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@vscodenpa vscodenpa added info-needed Issue requires more information from poster and removed ~info-needed Issue requires more information from poster (with bot comment) labels Mar 14, 2023
@HomyeeKing
Copy link
Author

HomyeeKing commented Mar 15, 2023

I search something at the extension detail page, then switch the tab, vscode got crash and exit

only can reproduce w/ the search operation(command + f), disable all the extension will be fine

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues electron Issues and items related to Electron labels Mar 15, 2023
@bpasero
Copy link
Member

bpasero commented Mar 15, 2023

This looks possibly like a crash from the iframe search changes we did?

@HomyeeKing
Can you please follow the steps in https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues to get at more details around the crash and attach the result here? Thanks!

cc @deepak1556

@HomyeeKing
Copy link
Author

no offend, doesn't the dump file contain some private information?
can you reproduce the issue at local and get the dmp yourself?

@bpasero
Copy link
Member

bpasero commented Mar 16, 2023

It should not contain private information, for example it does not contain any memory, but @deepak1556 can confirm.

@HomyeeKing
Copy link
Author

pending.zip

@rzhao271
Copy link
Contributor

Looks like there's a regression in the iframe search code
symbolicated-58-2.log

@EhabY
Copy link
Contributor

EhabY commented Sep 17, 2024

Is there a workaround for custom webviews such that VS Code does not crash even when enabling the "Find Widget"?

I don't want to disable this feature since it is very useful for our webviews...

@Prateek-Wayne
Copy link

Today I also faced this issue
when I open preview for markdown file
and then do some search then vs code crashes

@rzhao271
Copy link
Contributor

The current workaround is to close the find widget before switching away from the Markdown preview to prevent a crash.
I am reviewing some implementation details but have not had the time to create a patch in VS Code's Electron yet.

@rzhao271 rzhao271 modified the milestones: September 2024, October 2024 Sep 20, 2024
gjsjohnmurray added a commit to gjsjohnmurray/iris-package-manager that referenced this issue Sep 25, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 4, 2024
@gjsjohnmurray
Copy link
Contributor

No longer reproducible after Electron 32 bump 👍

Version: 1.95.0-insider
Commit: af6645a
Date: 2024-10-04T12:46:44.894Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.95.0-insider Chrome/128.0.6613.162 Electron/32.1.2 Safari/537.36

@andreamah andreamah added the verified Verification succeeded label Oct 22, 2024
@mro95
Copy link

mro95 commented Oct 29, 2024

I'm not sure if this is the same issue, but when I often switch tabs, the whole window will freeze.

Version: 1.94.2
Commit: 384ff73
Date: 2024-10-09T16:08:44.566Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Linux x64 6.11.4-amd64 (wayland)

@rzhao271
Copy link
Contributor

@mro95 if you mean editor tabs, that definitely sounds like a different issue. Could you file a new issue and attach a gif or video of the issue, please?

@0xcoinymous
Copy link

I faced this issue today.
when I move between a readme and its preview, the vs code crashed.
it happens so many times and still is happening.

@gjsjohnmurray
Copy link
Contributor

@0xcoinymous what version are you using?

@0xcoinymous
Copy link

@0xcoinymous what version are you using?

Version: 1.94.2 (system setup)
Commit: 384ff73
Date: 2024-10-09T16:08:44.566Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.19045

@gjsjohnmurray
Copy link
Contributor

Please update to the current release, 1.95.1

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron extensions-editor freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded webview Webview issues
Projects
None yet
18 participants