Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer re-showing Find widget when restoring hidden webview (may fix #177046) #229697

Closed
wants to merge 2 commits into from

Conversation

gjsjohnmurray
Copy link
Contributor

This is a speculative change which I hope will fix #177046. I am unable to determine whether or not it does because of #136476 (webview find widget doesn't work in OSS builds). Hence submitting the PR as a draft.

@gjsjohnmurray
Copy link
Contributor Author

@rzhao271 is there a way I can build and test this myself? If not please try it yourself when endgame pressure subsides. Or maybe you already tried my idea and found it made no difference.

@rzhao271
Copy link
Contributor

Hi John, thanks for the PR and the bump!
In this case, there are some internal processes involved and I had to test the change myself. I have confirmed that the program still crashes with your change on Electron 30.
Some good news is that Deepak and I have just merged in a change to Electron 32 to fix the issue on the internal Electron level.
Closing this PR. @deepak1556 could we make a tracking issue for Electron 32 adoption in VS Code?

@rzhao271 rzhao271 closed this Sep 30, 2024
@gjsjohnmurray gjsjohnmurray deleted the blush-orangutan branch September 30, 2024 20:43
@deepak1556
Copy link
Collaborator

deepak1556 commented Oct 1, 2024

You can track the progress for Electron 32 adoption in #218245

We will merge it once 1.94 release goes out.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

will crash after searching at extension panel
3 participants