Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer re-showing Find widget when restoring hidden webview (may fix #177046) #229697

Closed
wants to merge 2 commits into from
+2 −2
Closed

Defer re-showing Find widget when restoring hidden webview (may fix #177046) #229697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cfe11b
Defer re-showing Find widget when restoring hidden webview (may fix #…
gjsjohnmurray Sep 25, 2024
5816ad4
Merge branch 'main' into blush-orangutan
gjsjohnmurray Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/webview/browser/overlayWebview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,14 +278,14 @@ export class OverlayWebview extends Disposable implements IOverlayWebview {
this._firstLoadPendingMessages.clear();
}

this._container?.setVisibility('visible');

// https://github.com/microsoft/vscode/issues/157424
if (this.options.retainContextWhenHidden && this._shouldShowFindWidgetOnRestore) {
this.showFind(false);
// Reset
this._shouldShowFindWidgetOnRestore = false;
}

this._container?.setVisibility('visible');
}

public setHtml(html: string) {
Expand Down