Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge include/exclude search pattern inputs #45702

Closed
roblourens opened this issue Mar 13, 2018 · 5 comments
Closed

Merge include/exclude search pattern inputs #45702

roblourens opened this issue Mar 13, 2018 · 5 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
March 2018

Comments

@roblourens
Copy link
Member

Related to #45063

We should combine the include/exclude inputs in the search view. It's a waste of vertical space and I doubt that people use them heavily enough to justify two separate inputs. This also would match other editors.
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Mar 13, 2018
@roblourens roblourens added this to the March 2018 milestone Mar 13, 2018
@roblourens roblourens self-assigned this Mar 13, 2018
@roblourens
Copy link
Member Author

Do we still even need the ... menu?

@Abhijay
Copy link

Abhijay commented Mar 20, 2018 •
edited
Loading

How am I supposed to search for exclusive data types while ignoring certain folders?

e.g.

include: .js
exclude: /someFolderWithUnrelatedFiles/

@roblourens
Copy link
Member Author

I don't understand the problem, please open a new issue with more details.

@Crazy-P Crazy-P mentioned this issue Mar 22, 2018
Closed
@Crazy-P
Copy link

Crazy-P commented Mar 22, 2018 •
edited
Loading

I doubt that people use them heavily enough to justify two separate inputs. That statement is rather unjustified on its own.
The idea for the merged field is nice - but might as well be considered poor UI/ UX. 20-30 extra pixels doesn't do much.
If this is necessary, then I/we would like to have the option to use either 2 inputs or just 1 input field.

Reasons why are explained in this issue: #46315

@bpasero bpasero added the verified Verification succeeded label Mar 28, 2018
@acls
Copy link

acls commented Apr 6, 2018

Terrible idea. Please revert.

roblourens added a commit that referenced this issue Apr 19, 2018
@roblourens
Restore split include/exclude boxes
fac0095 
Revert "Fix #47157 - Focus include/exclude box when toggling open"

This reverts commit cf87ba3.

See #46315

Revert "Fix #46628 - wrong "no results found" message"

This reverts commit 0bd949c.

See #46315

Revert "Fix default search exclusions string"

This reverts commit 234d100.

See #46315

Revert "Improve migrating from split include/exclude inputs to the new merged one"

This reverts commit 22f49f8.

See #46315

Revert "Fix #45702 - merge include/exclude inputs"

This reverts commit 7fdf1e3.

See #46315
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
5 participants
@roblourens @acls @bpasero @Abhijay @Crazy-P