Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Toggle query details" should focus include/exclude box #47157

Closed
roblourens opened this issue Apr 3, 2018 · 1 comment
Closed

"Toggle query details" should focus include/exclude box #47157

roblourens opened this issue Apr 3, 2018 · 1 comment
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2018

Comments

@roblourens
Copy link
Member

  • Focus search widget
  • cmd+shift+j to show include/excludes
  • include/exclude should be focused
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Apr 3, 2018
@roblourens roblourens added this to the April 2018 milestone Apr 3, 2018
@roblourens roblourens self-assigned this Apr 3, 2018
roblourens added a commit that referenced this issue Apr 19, 2018
@roblourens
Restore split include/exclude boxes
fac0095 
Revert "Fix #47157 - Focus include/exclude box when toggling open"

This reverts commit cf87ba3.

See #46315

Revert "Fix #46628 - wrong "no results found" message"

This reverts commit 0bd949c.

See #46315

Revert "Fix default search exclusions string"

This reverts commit 234d100.

See #46315

Revert "Improve migrating from split include/exclude inputs to the new merged one"

This reverts commit 22f49f8.

See #46315

Revert "Fix #45702 - merge include/exclude inputs"

This reverts commit 7fdf1e3.

See #46315
@sandy081 sandy081 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Apr 25, 2018
@sandy081
Copy link
Member

The toggle is not focussing the include box

@sandy081 sandy081 reopened this Apr 25, 2018
@mjbvz mjbvz added verified Verification succeeded and removed verification-found Issue verification failed labels Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@roblourens @sandy081 @mjbvz