Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL Renderer: selection not rendered in background #86194

Closed
rebornix opened this issue Dec 3, 2019 · 2 comments · Fixed by #87920
Closed

WebGL Renderer: selection not rendered in background #86194

rebornix opened this issue Dec 3, 2019 · 2 comments · Fixed by #87920
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
January 2020

Comments

@rebornix
Copy link
Member

rebornix commented Dec 3, 2019

Re #85971

image

  • Open with WebGL rendering

image
image
@Tyriar Tyriar mentioned this issue Dec 4, 2019
Closed
@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2019

Upstream: xtermjs/xterm.js#2599

I think the problem with inverse is the only issue there? Let me know if I'm wrong.

@Tyriar Tyriar added terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream bug Issue identified by VS Code Team member as probable bug labels Dec 4, 2019
@Tyriar Tyriar added this to the Backlog milestone Dec 4, 2019
@rebornix
Copy link
Member Author

rebornix commented Dec 5, 2019

yup, that's the only issue I saw.

@Tyriar Tyriar modified the milestones: Backlog, January 2020 Dec 31, 2019
Tyriar added a commit that referenced this issue Dec 31, 2019
@Tyriar
xterm@4.4.0-beta.13
65df1d9 
xterm-addon-webgl@0.5.0-beta.7

Diff: xtermjs/xterm.js@8341c35...2a9e16b

- Include  in word separators xtermjs/xterm.js#2583
- Remove unused imports/functions xtermjs/xterm.js#2585
- force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560
- Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602
- v4.3.0 xtermjs/xterm.js#2605
- Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616
- Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590
- update version of node-pty xtermjs/xterm.js#2621
- Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625
- Expose texture atlas as API and use in demo xtermjs/xterm.js#2626
- Webgl v0.4.1 xtermjs/xterm.js#2628
- Add Linode to real world uses xtermjs/xterm.js#2636
- Added Gus to list of xterm real-world users xtermjs/xterm.js#2631
- Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637
- Move back to reseting parser only on RIS xtermjs/xterm.js#2640
- Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650
- format color value to style '#rrggbbaa' xtermjs/xterm.js#2629
- Use register over add for APIs returning disposables xtermjs/xterm.js#2651
- Standardize how colors helper lib is structured xtermjs/xterm.js#2653
- Fullwidth handling in buffer writes xtermjs/xterm.js#2644
- Target es5 in attach addon xtermjs/xterm.js#2654

Fixes #86194
Fixes #87918
Part of #87456
@Tyriar Tyriar mentioned this issue Dec 31, 2019
Merged
@rebornix rebornix added the verified Verification succeeded label Jan 29, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 14, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@4.4.0-beta.13
4342fdc 
xterm-addon-webgl@0.5.0-beta.7

Diff: xtermjs/xterm.js@8341c35...2a9e16b

- Include  in word separators xtermjs/xterm.js#2583
- Remove unused imports/functions xtermjs/xterm.js#2585
- force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560
- Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602
- v4.3.0 xtermjs/xterm.js#2605
- Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616
- Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590
- update version of node-pty xtermjs/xterm.js#2621
- Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625
- Expose texture atlas as API and use in demo xtermjs/xterm.js#2626
- Webgl v0.4.1 xtermjs/xterm.js#2628
- Add Linode to real world uses xtermjs/xterm.js#2636
- Added Gus to list of xterm real-world users xtermjs/xterm.js#2631
- Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637
- Move back to reseting parser only on RIS xtermjs/xterm.js#2640
- Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650
- format color value to style '#rrggbbaa' xtermjs/xterm.js#2629
- Use register over add for APIs returning disposables xtermjs/xterm.js#2651
- Standardize how colors helper lib is structured xtermjs/xterm.js#2653
- Fullwidth handling in buffer writes xtermjs/xterm.js#2644
- Target es5 in attach addon xtermjs/xterm.js#2654

Fixes microsoft#86194
Fixes microsoft#87918
Part of microsoft#87456
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
January 2020
Development

Successfully merging a pull request may close this issue.

xterm@4.4.0-beta.13 microsoft/vscode
2 participants
@rebornix @Tyriar