Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL renderer doesn't support hidden modifier #87918

Closed
Tyriar opened this issue Dec 31, 2019 · 2 comments · Fixed by #87920
Closed

WebGL renderer doesn't support hidden modifier #87918

Tyriar opened this issue Dec 31, 2019 · 2 comments · Fixed by #87920
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 31, 2019

From xtermjs/xterm.js#2596

Details

  • Browser and browser version: Code Insiders 2019-12-03
  • OS version: Windows 10

Steps to reproduce

Run this test script, notice the "hidden" text is not actually hidden when using the WebGL renderer:

const chalk = require('chalk');

const modifiers = ["reset", "bold", "dim", "italic", "underline", "inverse", "hidden", "strikethrough", "visible"];
const colors = ["black", "red", "green", "yellow", "blue", "magenta", "cyan", "white", "blackBright", "redBright", "greenBright", "yellowBright", "blueBright", "magentaBright", "cyanBright", "whiteBright"];

const colWidth = 20;

for (const modifier of modifiers) {
    process.stdout.write(chalk[modifier](modifier.padEnd(colWidth)));
}

process.stdout.write('\r\n');
for (const color of colors) {
    for (const modifier of modifiers) {
        process.stdout.write(chalk[modifier][color](color.padEnd(colWidth)));
    }
    process.stdout.write('\r\n');
}

#85971

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues accessibility-jaws a11ymas Issue from accessibility team labels Dec 31, 2019
@Tyriar Tyriar added this to the January 2020 milestone Dec 31, 2019
@Tyriar Tyriar self-assigned this Dec 31, 2019
Tyriar added a commit that referenced this issue Dec 31, 2019
xterm-addon-webgl@0.5.0-beta.7

Diff: xtermjs/xterm.js@8341c35...2a9e16b

- Include  in word separators xtermjs/xterm.js#2583
- Remove unused imports/functions xtermjs/xterm.js#2585
- force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560
- Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602
- v4.3.0 xtermjs/xterm.js#2605
- Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616
- Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590
- update version of node-pty xtermjs/xterm.js#2621
- Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625
- Expose texture atlas as API and use in demo xtermjs/xterm.js#2626
- Webgl v0.4.1 xtermjs/xterm.js#2628
- Add Linode to real world uses xtermjs/xterm.js#2636
- Added Gus to list of xterm real-world users xtermjs/xterm.js#2631
- Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637
- Move back to reseting parser only on RIS xtermjs/xterm.js#2640
- Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650
- format color value to style '#rrggbbaa' xtermjs/xterm.js#2629
- Use register over add for APIs returning disposables xtermjs/xterm.js#2651
- Standardize how colors helper lib is structured xtermjs/xterm.js#2653
- Fullwidth handling in buffer writes xtermjs/xterm.js#2644
- Target es5 in attach addon xtermjs/xterm.js#2654

Fixes #86194
Fixes #87918
Part of #87456
@Tyriar Tyriar removed a11ymas Issue from accessibility team accessibility-jaws labels Jan 29, 2020
@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2020

Window 10
Version: 1.42.0-insider (user setup) 
8d4cdbaa8d64514a5eb3b186b9a31b66cd8a9753
Date: 2020-01-31T08:56:44.663Z

I ran the sample above in the integrated terminal.
Also I tried all the options of "terminal.integrated.rendererType", including "experimentalWebgl"

Hidden never seem to be hidden.
image

Sorry If I misunderstood the issue.

@aeschli aeschli reopened this Jan 31, 2020
@aeschli aeschli added the verification-found Issue verification failed label Jan 31, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Jan 31, 2020

Hmm, it's working for me. Try this stripped down repro case in bash:

echo -e '\x1b[8mhidden\x1b[0mnot'

@Tyriar Tyriar closed this as completed Jan 31, 2020
@Tyriar Tyriar removed the verification-found Issue verification failed label Jan 31, 2020
@rebornix rebornix added the verified Verification succeeded label Jan 31, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 16, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
xterm-addon-webgl@0.5.0-beta.7

Diff: xtermjs/xterm.js@8341c35...2a9e16b

- Include  in word separators xtermjs/xterm.js#2583
- Remove unused imports/functions xtermjs/xterm.js#2585
- force alpha to 1 when using background color as inverted foreground color xtermjs/xterm.js#2560
- Fix minimumContrastRatio on dom/truecolor xtermjs/xterm.js#2602
- v4.3.0 xtermjs/xterm.js#2605
- Avoid roundtrip to browser when double-disposing. xtermjs/xterm.js#2616
- Allow the thickness of the bar cursor to be configured xtermjs/xterm.js#2590
- update version of node-pty xtermjs/xterm.js#2621
- Implement hidden in DOM and WebGL renderers xtermjs/xterm.js#2625
- Expose texture atlas as API and use in demo xtermjs/xterm.js#2626
- Webgl v0.4.1 xtermjs/xterm.js#2628
- Add Linode to real world uses xtermjs/xterm.js#2636
- Added Gus to list of xterm real-world users xtermjs/xterm.js#2631
- Remove a large portion of InputHandler's dependency on Terminal xtermjs/xterm.js#2637
- Move back to reseting parser only on RIS xtermjs/xterm.js#2640
- Set glyph fg color based on original bg, not selection xtermjs/xterm.js#2650
- format color value to style '#rrggbbaa' xtermjs/xterm.js#2629
- Use register over add for APIs returning disposables xtermjs/xterm.js#2651
- Standardize how colors helper lib is structured xtermjs/xterm.js#2653
- Fullwidth handling in buffer writes xtermjs/xterm.js#2644
- Target es5 in attach addon xtermjs/xterm.js#2654

Fixes microsoft#86194
Fixes microsoft#87918
Part of microsoft#87456
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants