Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt ensureNoDisposablesLeaked in code action model tests #209279

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+24 −20
Open

adopt ensureNoDisposablesLeaked in code action model tests #209279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d8f0dee
adopt ensureNoDisposables
justschen Apr 1, 2024
a2f7e04
fix the leaky leak
justschen Apr 1, 2024
ee71421
passing tests, but TS error
justschen Apr 1, 2024
2394fcc
better fix, put disposal behind try/catch
justschen Apr 2, 2024
4d25e85
better fix, put disposal behind try/catch
justschen Apr 2, 2024
2907961
switch to using disposable store
justschen Apr 2, 2024
f005f2e
add timeout for disposable
justschen Apr 2, 2024
a18a742
remove extra disposables
justschen Apr 19, 2024
0dcb64a
another extra disposable store removal
justschen Apr 19, 2024
a5dc84c
Adds back using disposable store, no more leaking
justschen Apr 19, 2024
88f4711
clear and dispose?
justschen Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@
"src/vs/base/test/browser/browser.test.ts",
"src/vs/base/test/browser/ui/scrollbar/scrollableElement.test.ts",
"src/vs/base/test/browser/ui/scrollbar/scrollbarState.test.ts",
"src/vs/editor/contrib/codeAction/test/browser/codeActionModel.test.ts",
"src/vs/editor/test/common/services/languageService.test.ts",
"src/vs/editor/test/node/classification/typescript.test.ts",
"src/vs/platform/configuration/test/common/configuration.test.ts",
Expand Down
3 changes: 3 additions & 0 deletions src/vs/editor/contrib/codeAction/test/browser/codeActionModel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { DisposableStore } from 'vs/base/common/lifecycle';
import { assertType } from 'vs/base/common/types';
import { URI } from 'vs/base/common/uri';
import { runWithFakedTimers } from 'vs/base/test/common/timeTravelScheduler';
import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
import { ICodeEditor } from 'vs/editor/browser/editorBrowser';
import { LanguageFeatureRegistry } from 'vs/editor/common/languageFeatureRegistry';
import * as languages from 'vs/editor/common/languages';
Expand Down Expand Up @@ -49,6 +50,8 @@ suite('CodeActionModel', () => {
registry = new LanguageFeatureRegistry();
});

ensureNoDisposablesAreLeakedInTestSuite();

teardown(() => {
disposables.clear();
editor.dispose();
Expand Down
Loading