Fix lifecycle for code actions that are updated while the code action menu is already showing #76917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… menu is already showing Fixes microsoft#76851 In the following case 1. Code action list is shown 1. We then update the code actions in the background (possibly because extensions took a little while to compute them) 1. The user accepts a code action At step 2, we release the previous code action list which causes all of its actions to be gabage collected **Fix** Move lifecycle management of the code actions into the two consumers. Will look into make the code safer with a follow up fix
octref
approved these changes
Jul 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76851
In the following case
At step 2, we release the previous code action list which causes all of its actions to be gabage collected
Fix
Move lifecycle management of the code actions into the two consumers. Will look into make the code safer with a follow up fix