Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifecycle for code actions that are updated while the code action menu is already showing #76917

Merged
merged 1 commit into from
Jul 8, 2019

Commits on Jul 8, 2019

  1. Fix lifecycle for code actions that are updated while the code action…

    … menu is already showing
    
    Fixes microsoft#76851
    
    In the following case
    
    1. Code action list is shown
    1. We then update the code actions in the background (possibly because extensions took a little while to compute them)
    1. The user accepts a code action
    
    At step 2, we release the previous code action list which causes all of its actions to be gabage collected
    
    **Fix**
    Move lifecycle management of the code actions into the two consumers. Will look into make the code safer with a follow up fix
    mjbvz committed Jul 8, 2019
    1 Configuration menu
    Copy the full SHA
    efac204 View commit details
    Browse the repository at this point in the history