Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide workbench.panel.location "top" option (microsoft#50984) #93653

Closed
wants to merge 2 commits into from

Conversation

ika-musuko
Copy link

This PR fixes #50984

@msftclas
Copy link

msftclas commented Mar 28, 2020

CLA assistant check
All CLA requirements met.

@ika-musuko
Copy link
Author

ika-musuko commented Mar 30, 2020

I don't use Windows so I'm not sure how to fix the CI bug there. Please let me know how this can be fixed.

EDIT: now windows passed but macOS fails lol. I don't use that either.

@joaomoreno joaomoreno changed the base branch from master to main February 15, 2021 08:51
@joaomoreno joaomoreno assigned benibenj and unassigned sbatten May 31, 2024
@benibenj
Copy link
Contributor

benibenj commented Jun 8, 2024

Thank you for contributing and I'm sorry about the long wait here. We actually have a newer PR which attempts to solve this problem and as I can see that there are many conflicts here, I'll close this one in favour of the other PR:
#207721

@benibenj benibenj closed this Jun 8, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide workbench.panel.location "top" option
4 participants