Multi Profile Support - Part 1 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddyett
reviewed
Jun 11, 2020
ddyett
reviewed
Jun 15, 2020
ddyett
reviewed
Jun 15, 2020
ddyett
reviewed
Jun 15, 2020
ddyett
reviewed
Jun 15, 2020
src/Authentication/Authentication/Extensions/PSCmdletExtensions.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Jun 15, 2020
src/Authentication/Authentication/Extensions/PSCmdletExtensions.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Jun 15, 2020
src/Authentication/Authentication/Extensions/StringExtensions.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Jun 15, 2020
| /// </summary> | ||
| /// <param name="profileName">The name of a profile.</param> | ||
| /// <returns>A full description of a profile.</returns> | ||
| internal static string GetProfileDescription(string profileName) |
There was a problem hiding this comment.
consider whether these mapping should just be a json file for maintainability.
There was a problem hiding this comment.
Moving the mapping to a json fill will result in duplicate descriptions; per cloud per api version. We don't expect the sovreign clouds and API versions to change frequently.
ddyett
reviewed
Jun 15, 2020
2 tasks
ddyett
previously approved these changes
Jun 26, 2020
ddyett
approved these changes
Jun 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is divided into 2 parts, part 1 of this PR closes #72, AB#4769 by proposing the following changes:
tools/GenerateProfiles.ps1script which will generate profiles definition files from downloaded OpenAPI files.readme.mdthat imports all supported profiles, and input-files to the profile's OpenAPI doc e.g. Users.User module profile readme.tools/GenerateModules.ps1to add supported profiles to a modules manifest (.psd1). This will be used byGet-MgProfile -ListAvailableto get all supported profiles. e.g. Users.User module manifest.src/Authentication/Authentication/Cmdlets/GetMgProfile.csandsrc/Authentication/Authentication/Cmdlets/SelectMgProfile.csto manage supported Microsoft Graph Profiles.The profile definitions will be generated, and consumed to generate modules as show below:
Profiles in actions
Part 2 of this PR has the profiles generated by
tools/GenerateProfiles.ps1, an updated project structure, and a complete regeneration of all modules using v1.0 & beta OpenAPI docs.