Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Profile Support - Part 2 #255

Merged
merged 24 commits into from
Jul 17, 2020
Merged

Multi Profile Support - Part 2 #255

merged 24 commits into from
Jul 17, 2020

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented Jun 10, 2020

This is part 2 of PR #254. This PR contains the following changes:

  • Generates module profiles using tools in PR Multi Profile Support - Part 1 #254 .
  • Updates the structure of the repo by moving generated modules from ./src/beta/{moduleName} to ./src/{moduleName}.
  • Updates custom cmdlets to target supported profiles.
  • Adds directives to resolve cmdlet naming conflicts in v1.0.
  • Regenerated all modules using v1.0 & beta OpenAPI docs.

@peombwa peombwa changed the base branch from milestone/0.7.0 to po/multiprofile June 10, 2020 00:50
@peombwa peombwa changed the base branch from po/multiprofile to milestone/0.7.0 June 10, 2020 00:52
@peombwa peombwa marked this pull request as ready for review June 10, 2020 17:22
@peombwa peombwa self-assigned this Jun 10, 2020
@peombwa peombwa changed the base branch from milestone/0.7.0 to milestone/0.9.0 June 17, 2020 17:54
@peombwa peombwa mentioned this pull request Jun 23, 2020
2 tasks
ddyett
ddyett previously approved these changes Jun 26, 2020
Copy link
Contributor

@ddyett ddyett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs a refresh though since it's been out for a while.

@peombwa peombwa changed the base branch from milestone/0.9.0 to dev June 29, 2020 15:49
@peombwa peombwa dismissed ddyett’s stale review June 29, 2020 15:49

The base branch was changed.

@peombwa peombwa requested a review from ddyett June 29, 2020 18:30
ddyett
ddyett previously approved these changes Jun 29, 2020
ddyett
ddyett previously approved these changes Jul 15, 2020
Copy link
Contributor

@ddyett ddyett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADO changes look fine.

@peombwa peombwa merged commit 3482bb3 into dev Jul 17, 2020
@peombwa peombwa deleted the po/mutliProfileProjStructure branch July 17, 2020 21:52
@peombwa peombwa mentioned this pull request Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants