Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #120

Merged
merged 22 commits into from
May 14, 2021
Merged

UI improvements #120

merged 22 commits into from
May 14, 2021

Conversation

CasperVerswijvelt
Copy link
Contributor

Many small ui improvements

  • Consistent spacing between titles and content
  • Removed many ugly text squishing by hiding overflowing text with ellipsis
  • Removed hardcoded max length for certain names/urls/etc. and use css overflow: ellipsis instead
  • Fixed Service or location favicon being squished by long service or location name
  • Hide scrollbar in 'more session' screen when content isn't scrollable
  • Fix apexcharts tooltips and labels being cut off by card class
  • Improve responsiveness in general

Copy link
Owner

@milesmcc milesmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for these changes. I'll take a closer look near the next release, but just had a quick question about the new <a> tags in the meantime.

Looks great!

shynet/dashboard/templates/base.html Outdated Show resolved Hide resolved
@CasperVerswijvelt
Copy link
Contributor Author

Codacy Static code analysis seems to expect 2 spaces as indentation but everything in that file has 4 spaces so I'll just leave it

@milesmcc
Copy link
Owner

Rebased, squashed, and merged into dev.

@JuniorJPDJ
Copy link
Contributor

Close it then :X

@milesmcc
Copy link
Owner

@JuniorJPDJ pull requests are automatically closed when they are merged into master (i.e., for release). Is something wrong?

@JuniorJPDJ
Copy link
Contributor

Oh nvm, I thought it bugged bcs of squashing.

@milesmcc
Copy link
Owner

Oh nvm, I thought it bugged bcs of squashing.

Got it, cool. I'm planning on packaging the new release later today so it shouldn't be long.

@milesmcc milesmcc merged commit 0b78f6d into milesmcc:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants