Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker mobile overflow #143

Merged
merged 2 commits into from
May 23, 2021
Merged

Datepicker mobile overflow #143

merged 2 commits into from
May 23, 2021

Conversation

CasperVerswijvelt
Copy link
Contributor

Made it so the date picker auto shrinks on smaller displays, this is something I messed up in #120.

Before After
analytics casperverswijvelt be_dashboard_service_ba385d2a-5c80-4b31-931e-3da309fac8d0_(iPhone 5_SE) 192 168 69 11_4848_dashboard_service_db3c54c6-e9e5-44f2-bfd1-8ea8296c327d__startDate=2020-1-31 endDate=2020-1-31(iPhone 5_SE)

Also gave the date picker element a smaller fixed width since width: auto does not work on the value of input elements, and there was always some white space.

Before After
analytics casperverswijvelt be_dashboard_service_ba385d2a-5c80-4b31-931e-3da309fac8d0_(iPad) 192 168 69 11_4848_dashboard_service_db3c54c6-e9e5-44f2-bfd1-8ea8296c327d__startDate=2020-1-31 endDate=2020-1-31(iPad)

milesmcc
milesmcc approved these changes May 23, 2021
View reviewed changes
Copy link
Owner

@milesmcc milesmcc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@milesmcc milesmcc merged commit a4785b1 into milesmcc:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesmcc milesmcc milesmcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CasperVerswijvelt @milesmcc