"Fix" outputting to terminal every search! #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wouldn't say it fixes mileszs#18 and mileszs#52, but it builds on them. It avoids the compatibility woes, but only using the shell trick if the shell is bash or zsh. Otherwise it does the t_te/i swapping. Both are not very neat, and make this function messier, but making 3 separate functions seemed a lot more busy work.
|
I know this is a hotly debated "this fix doesn't work for everyone" topic, but this at least collates the two main camps in to one ugly workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wouldn't say it fixes #18 and #52, but it builds on them. It avoids
the compatibility woes, but only using the shell trick if the shell is
bash or zsh. Otherwise it does the t_te/i swapping.
Both are not very neat, and make this function messier, but making 3
separate functions seemed a lot more busy work.