Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents ack output to bleed into the host terminal. (Issue 18) #52

Closed
wants to merge 1 commit into from

Conversation

rvega
Copy link

@rvega rvega commented Nov 10, 2012

Prevents ack output to bleed into the host terminal.

Prevents ack output to bleed into the host terminal.
@ZyX-I
Copy link

ZyX-I commented Nov 10, 2012

Hope this won’t get merged. Details in issue #18.

@rvega
Copy link
Author

rvega commented Nov 13, 2012

@ZyX-I : I see. Thanks for jumping in and commenting.

@mileszs
Copy link
Owner

mileszs commented Nov 22, 2012

I'm going to close this until we can find a more universal solution.

@mileszs mileszs closed this Nov 22, 2012
@ZyX-I
Copy link

ZyX-I commented Nov 22, 2012

@mileszs I already pointed to it: system() (probably something like readsystem if you expect NUL bytes in output), setqflist/setloclist and parsing of ack output without the help of vim (I mean 'errorformat' option).

From my point of view this is not the thing you should bother about, just add non-universal solution to the doc saying that it should be set in the vimrc and disable intrusive behavior for all :*grep* commands, not just in this plugin. It already should not bother cmd.exe users, dash ones will be satisfied with changing &> to 2>&1 > (works in bash and zsh as well) and tcsh have to deduce something else.

@mollerhoj
Copy link

After using this patch, :Ack still jumps out of vim. (Nothing is written to the terminal, though). This could be avoided by doing: "set t_ti= t_te=". But then vim is seen in the terminal after pressing ctrl-z.

barn added a commit to barn/ack.vim that referenced this pull request Oct 23, 2021
I wouldn't say it fixes mileszs#18 and mileszs#52, but it builds on them. It avoids
the compatibility woes, but only using the shell trick if the shell is
bash or zsh. Otherwise it does the t_te/i swapping.

Both are not very neat, and make this function messier, but making 3
separate functions seemed a lot more busy work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants