Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separators disappearing on ALT+TAB #120

Closed
manuel-uberti opened this issue May 5, 2016 · 16 comments
Closed

Separators disappearing on ALT+TAB #120

manuel-uberti opened this issue May 5, 2016 · 16 comments

Comments

@manuel-uberti
Copy link

I think it's easier to explain this issue with some pictures:

2016-05-05-171533_1919x63_scrot

This happens with all the separators:

2016-05-05-171707_1919x65_scrot

It also happens with a different theme:

2016-05-05-171850_1919x79_scrot

And with emacs -Q as well:

2016-05-05-172008_1919x60_scrot

I am using latest powerline from MELPA, on GNU Emacs 25.0.93.1 (x86_64-debian-linux-gnu, GTK+ Version 3.14.5) of 2016-05-05.

All I do is switching between windows with ALT+TAB, and upon returning on the Emacs windows this is what I see.

@manuel-uberti
Copy link
Author

Don't know if it could be of any help, but everything works fine with this fork by @abo-abo: https://github.com/abo-abo/powerline

@manuel-uberti
Copy link
Author

Nothing here? :)

@abo-abo
Copy link
Contributor

abo-abo commented May 11, 2016

@manuel-uberti
See counsel-load-theme-action, it calls powerline-reset to change the mode line fringe colors.

And may I say that I really like the theme you're using:)

@manuel-uberti
Copy link
Author

You don't say ;)

Anyways, with latest Powerline from MELPA the issue is still present.

@manuel-uberti
Copy link
Author

ping :)

@milkypostman
Copy link
Owner

i'm confused about what the resolution is here? @abo-abo should we integrate your changes?

@abo-abo
Copy link
Contributor

abo-abo commented May 17, 2016

@milkypostman Wouldn't hurt I guess, they're fairly innocuous.

But since the changes are a year old, I think the current problem is due to the presence of the new changes in the mainline, rather than the absence of my changes.

Try to git bisect the problem across the commits made in the past year.

@manuel-uberti
Copy link
Author

anything? :)

@manuel-uberti
Copy link
Author

ping :)

@milkypostman
Copy link
Owner

sorry to be silent but I don't have time to debug the issue. I would suggest that someone from the community try to figure out what is wrong. I'm happy to accept PRs.

@manuel-uberti
Copy link
Author

I tried merging @abo-abo repo with latest commits on this main repo, but still nothing. Hard to understand what goes wrong, sorry. :(

@stiell
Copy link

stiell commented Aug 9, 2016

Looks like this bug was introduced in 3b0f508.

As I understand it, that commit makes powerline treat the window as inactive upon receiving a WM focus-out event, while Emacs' own mode line handling apparently does not. This results in a mismatch between the separator which expects mode-line-inactive and the neighbouring part which uses the mode-line face.

stiell added a commit to stiell/powerline that referenced this issue Aug 9, 2016
Remove the stack of minibuffer selected windows.  Instead consider
(minibuffer-selected-window) the selected window whenever
(selected-window) is a minibuffer.  This seems to be consistent with
what Emacs considers the selected window when choosing the mode line
face.

Also update all mode lines whenever a new window is selected, as
either the previously or the newly selected window would in some cases
not update, resulting in either two or zero windows apparently selected.

Fixes milkypostman#120
@manuel-uberti
Copy link
Author

Still ugly with Solarized light.
powerline

@manuel-uberti
Copy link
Author

There seem to be no solution for this. Should I close this issue and forget about it? :)

@abo-abo
Copy link
Contributor

abo-abo commented Dec 2, 2016

@manuel-uberti Try (remove-hook 'focus-out-hook 'powerline-unset-selected-window).

@manuel-uberti
Copy link
Author

@abo-abo same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants