Fix and simplify detection of selected window #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the stack of minibuffer selected windows. Instead consider (minibuffer-selected-window) the selected window whenever (selected-window) is a minibuffer. This seems to be consistent with what Emacs considers the selected window when choosing the mode line face. Also update all mode lines whenever a new window is selected, as either the previously or the newly selected window would in some cases not update, resulting in either two or zero windows apparently selected. Fixes milkypostman#120
|
Any chance this can be merged? |
|
Actually, I am afraid but this PR doesn't fix it for me. Running |
|
That looks to me like a different bug in the particular theme you are using. |
|
It happens with the default powerline theme as well. |
|
Here's a screenshot with the default theme: |
|
Same display bug on Windows 10, by the way: |
|
@manuel-uberti does this fix your problem? |
|
As reported above, it didn't. Although I haven't tried in a while since I move to a custom mode line and a different theme. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the stack of minibuffer selected windows. Instead consider
(minibuffer-selected-window) the selected window whenever
(selected-window) is a minibuffer. This seems to be consistent with
what Emacs considers the selected window when choosing the mode line
face.
Also update all mode lines whenever a new window is selected, as
either the previously or the newly selected window would in some cases
not update, resulting in either two or zero windows apparently selected.
Fixes #120
I've tested this using Emacs 24.5. Moving between frames and windows including nested minibuffers I couldn't find any inconsistencies.